Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove unused functions (#1590) #1698

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

feat: remove unused functions (#1590) #1698

wants to merge 1 commit into from

Conversation

bjohansebas
Copy link
Member

The second PR, which is part of #1590, removes unused functionalities from the page.

@bjohansebas bjohansebas requested review from chrisdel101 and a team November 25, 2024 00:36
@bjohansebas bjohansebas self-assigned this Nov 25, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 25, 2024 •
edited
Loading

✅ Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 04aa2df
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/6743c6963787230008378fdc
😎 Deploy Preview https://deploy-preview-1698--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bjohansebas bjohansebas mentioned this pull request Nov 25, 2024
Open
5 tasks
chrisdel101
chrisdel101 reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@chrisdel101 chrisdel101 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any bugs in the site working. I don't really know what mobile js does but I never used it so happy to see it go.
I added some ideas. These are suggestions only. I'd recommend but up to you if you agree.
Good idea doing this.

js/app.js Show resolved Hide resolved
js/app.js Show resolved Hide resolved
js/app.js Show resolved Hide resolved
js/app.js Show resolved Hide resolved
js/app.js Show resolved Hide resolved
js/app.js Show resolved Hide resolved
@bjohansebas bjohansebas mentioned this pull request Nov 27, 2024
Open
chrisdel101
chrisdel101 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@chrisdel101 chrisdel101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okie if you're doing these later than I guess overall I'd just like a one line comment on all non-super obvious JS funcs in the next iteration.
Otherwise I don't see these changes break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdel101 chrisdel101 chrisdel101 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@bjohansebas bjohansebas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjohansebas @chrisdel101