Feat/adjust in home poc #1706
Merged
Feat/adjust in home poc #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I like it, I don't think we should add the quick example title. |
bjohansebas
reviewed
Dec 5, 2024
pt-br/index.md
Outdated
| <div id="middleware" class="feature-box"> | ||
| <h3>Middleware</h3> | ||
| <p>Estenda as funcionalidades do Express através de middleware. Desde autenticação até compressão, existe um middleware para cada necessidade da sua aplicação.</p> | ||
| <a href="{{ page.lang }}/guide/using-middleware.html" class="learn-more">Saiba mais →</a> |
There was a problem hiding this comment.
There was always this 404, it's time to fix it.
Suggested change
| <a href="{{ page.lang }}/guide/using-middleware.html" class="learn-more">Saiba mais →</a> | |
| <a href="/{{ page.lang }}/guide/using-middleware.html" class="learn-more">Saiba mais →</a> |
bjohansebas
reviewed
Dec 5, 2024
wesleytodd
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Agreed with @bjohansebas on not needing the title, but other than that I like it a lot!
|
@bjohansebas @UlisesGascon @wesleytodd I made some modifications to leave a smaller change to be implemented in small steps, could you review it again? |
bjohansebas
requested changes
Jan 9, 2025
bjohansebas
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing changes to the structure of the home page
Before:
After:
** I made the changes only in the pt-br language just to illustrate
LINK PREVIEW IN PT-BR https://deploy-preview-1706--expressjscom-preview.netlify.app/pt-br/