Basic changes are made #320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @whoami1432! Thanks for opening a PR and help us improve the generator 😄 We currently don't support ES6 syntax as the project is supporting [email protected] (see: https://github.com/expressjs/generator/blob/master/.github/workflows/ci.yml#L14). I enabled the CI, so you can debug better the changes that you are suggesting 👍 |
|
@UlisesGascon how about creating a new repo in this org called "generator-esm"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I added the use strict for .js files and changed the var into const then while sending response and redirect we return it.