Configure statusboard #1

wesleytodd · 2019-08-15T07:11:09Z

Setting up the integration of @pkgjs/statusboard. More to come.

This is the start, but there is much more work to do: https://expressjs.github.io/statusboard

wesleytodd · 2020-04-22T20:13:00Z

@andrewhughes101 @jonchurch Looks good right?

https://expressjs.github.io/statusboard/

jonchurch · 2020-04-22T21:55:57Z

Seems to be working 🎉

Do you want reviews on this PR yet or is it still a WIP?

I was going to ask about the pull_request trigger in the workflow (is it just for testing atm? It will update gh-pages whenever a new PR is opened), and testing it with fetching by org instead of individual projects.

wesleytodd · 2020-04-24T16:56:43Z

Yeah specific review here would be good. Now that you mention that I am digging though this and it is sloppy. I think you are right that I added that for testing so that needs to be removed. I can look at that today, but any review you have would be valuable so I can merge it right after doing the cleanup.

jonchurch · 2020-04-24T19:19:54Z

index.js

+    projects: [
+      'expressjs/express',
+      'expressjs/discussions',
+      'expressjs/cors',
+      'expressjs/morgan',
+      'expressjs/response-time',
+      'expressjs/session',
+      'expressjs/multer',
+      'expressjs/body-parser',
+      'expressjs/compression',
+      'expressjs/serve-static',
+      'expressjs/errorhandler',
+      'expressjs/serve-index',
+      'expressjs/csurf',
+      'expressjs/timeout',
+      'expressjs/flash',
+      'expressjs/vhost',
+
+      'pillarjs/router',
+      'pillarjs/cookies',
+      'pillarjs/send',
+      'pillarjs/finalhandler',
+      'pillarjs/path-to-regexp',
+
+      'jshttp/cookie',
+      'jshttp/fresh',
+      'jshttp/content-disposition',
+      'jshttp/mime-db',
+      'jshttp/media-typer',
+      'jshttp/range-parser',
+      'jshttp/type-is',
+      'jshttp/accepts',
+      'jshttp/negotiator',
+      'jshttp/mime-types',
+      'jshttp/compressible',
+      'jshttp/content-type',
+      'jshttp/http-errors',
+      'jshttp/proxy-addr',
+      'jshttp/etag',
+      'jshttp/forwarded',
+      'jshttp/on-finished',
+      'jshttp/on-headers',
+      'jshttp/vary',
+      'jshttp/basic-auth',
+      'jshttp/methods',
+      'jshttp/statuses'
+    ],
+


Suggested change

projects: [

'expressjs/express',

'expressjs/discussions',

'expressjs/cors',

'expressjs/morgan',

'expressjs/response-time',

'expressjs/session',

'expressjs/multer',

'expressjs/body-parser',

'expressjs/compression',

'expressjs/serve-static',

'expressjs/errorhandler',

'expressjs/serve-index',

'expressjs/csurf',

'expressjs/timeout',

'expressjs/flash',

'expressjs/vhost',

'pillarjs/router',

'pillarjs/cookies',

'pillarjs/send',

'pillarjs/finalhandler',

'pillarjs/path-to-regexp',

'jshttp/cookie',

'jshttp/fresh',

'jshttp/content-disposition',

'jshttp/mime-db',

'jshttp/media-typer',

'jshttp/range-parser',

'jshttp/type-is',

'jshttp/accepts',

'jshttp/negotiator',

'jshttp/mime-types',

'jshttp/compressible',

'jshttp/content-type',

'jshttp/http-errors',

'jshttp/proxy-addr',

'jshttp/etag',

'jshttp/forwarded',

'jshttp/on-finished',

'jshttp/on-headers',

'jshttp/vary',

'jshttp/basic-auth',

'jshttp/methods',

'jshttp/statuses'

],

projects: [],

orgs: [

"jshttp",

"pillarjs",

"expressjs"

]

My preference is to do this by orgs

So I dropped some from the list which are unmaintained or deprecated. We talked about moving them out of the orgs, but haven't yet. I do agree if we get those cleaned up it would be better to do what you are saying.

I did move a couple more out recently (I think 2 months ago) but we do need to go through them. Those repos wouldn't really contribute anything to the stats, though. Is not listing them just to like make the loading process faster?

Not listing them was mainly so users or triagers did not spend time on them. But if we think everything remaining in the repo is good, then the next step would be to add support for specifying orgs and pulling a list of repos to populate data from. This is not supported today in @pkgjs/statusboard, but should be IMO.

wesleytodd · 2020-04-24T19:25:55Z

.github/workflows/build.yml

+on:
+  pull_request:
+    branches:
+      - master


This is the part we should remove.

wesleytodd · 2020-04-24T19:26:29Z

.github/workflows/build.yml

+        git config user.email "<>"
+        git config user.name "${GITHUB_ACTOR}"
+    - name: Setup gh-pages branch
+      run: |


This whole part should be replaced with https://github.com/pkgjs/gh-pages/

That is the whole reason I made that action in the first place.

wesleytodd · 2020-04-24T19:27:06Z

.github/workflows/publish.yml

@@ -0,0 +1,32 @@
+name: Publish GPR Package


I think we should just remove this. This was me testing what this would look like as a published package. I am not sure there is value in this.

Makes sense. I was curious what the package was for.

Yeah, it was a bit weird, but I was publishing the entire dataset as a package where the wrapper around @pkgjs/statusboard was the interface. I guess my thought was that something in theory could consume the statusboard data from multiple communities and pull them together. For example if the OpenJS Foundation wanted to have a board with all the project activity together, they could import all of the individual projects and build a view from that. I still think it is an interesting idea, but of little value to us today.

Ah. That is an interesting idea, though, especially with the amount of time it takes to generate the data just for our repos, it would make sense to have a static copy to build off of. But yea, agree no use to us currently. But fun to experiment with the package publishing I'm sure 😄

it would make sense to have a static copy to build off of

Yeah that is what the published package is. It is literally the leveldb database 🤪

EDIT: Well I think it is. That is what I intended to do and I cant remember now if that is what I actually did. Again, doesn't matter since it is unnecessary.

wesleytodd · 2020-04-24T19:28:31Z

index.js

+      'jshttp/statuses'
+    ],
+
+    teams: {


All of this is also not used currently by the status board. But my intent was to use this to display an updated list of members. Now that I look at it, it would be better to have the status board pull the list of teams from GitHub, not the other way around.

jonchurch

I think it's good to go, just suggested removing vestigial parts

jonchurch · 2020-05-20T18:25:36Z

.github/workflows/build.yml

+  pull_request:
+    branches:
+      - master


Suggested change

pull_request:

branches:

- master

jonchurch · 2020-05-20T18:27:56Z

.github/workflows/publish.yml

+name: Publish GPR Package
+
+on:
+  push:
+    branches:
+      - master
+
+jobs:
+  publish-gpr:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v1
+      - name: Setup git user
+        run: |
+          git config user.email "<>"
+          git config user.name "${GITHUB_ACTOR}"
+      - uses: actions/setup-node@v1
+        with:
+          node-version: 12
+          registry-url: https://npm.pkg.github.com/
+          scope: '@expressjs'
+      - name: NPM Install
+        run: npm i
+      - name: NPM Version
+        run: npm version prerelease --preid="${GITHUB_SHA}"
+      - name: NPM Publish
+        run: npm publish
+        env:
+          NODE_AUTH_TOKEN: ${{secrets.GH_TOKEN}}
+      - name: Push version and tag
+        run: |
+          git push https://wesleytodd:${{secrets.GH_TOKEN}}@github.com/${GITHUB_REPOSITORY}.git --tags


Suggested change

name: Publish GPR Package

on:

push:

branches:

- master

jobs:

publish-gpr:

runs-on: ubuntu-latest

steps:

- uses: actions/checkout@v1

- name: Setup git user

run: |

git config user.email "<>"

git config user.name "${GITHUB_ACTOR}"

- uses: actions/setup-node@v1

with:

node-version: 12

registry-url: https://npm.pkg.github.com/

scope: '@expressjs'

- name: NPM Install

run: npm i

- name: NPM Version

run: npm version prerelease --preid="${GITHUB_SHA}"

- name: NPM Publish

run: npm publish

env:

NODE_AUTH_TOKEN: ${{secrets.GH_TOKEN}}

- name: Push version and tag

run: |

git push https://wesleytodd:${{secrets.GH_TOKEN}}@github.com/${GITHUB_REPOSITORY}.git --tags

jonchurch · 2020-05-20T18:30:55Z

index.js

+    teams: {
+      technicalCommitee: [{
+        name: 'Doug Wilson',
+        github: 'dougwilson',
+        npm: 'dougwilson',
+        twitter: 'blipsofadoug',
+        email: '[email protected]'
+      }, {
+        name: 'Jonathan Ong',
+        github: 'jonathanong',
+        npm: 'jongleberry',
+        twitter: 'jongleberry',
+        email: '[email protected]',
+        avatar: '6e33cc0412b61cc01daac23c8989003c'
+      }, {
+        name: 'Jeremiah Senkpiel',
+        github: 'fishrock123',
+        npm: 'fishrock123',
+        twitter: 'fishrock123',
+        email: '[email protected]'
+      }, {
+        name: 'Alex Kocharin',
+        github: 'rlidwka',
+        npm: 'rlidwka',
+        twitter: 'rlidwka',
+        email: '[email protected]'
+      }, {
+        name: 'Linus Unnebäck',
+        github: 'LinusU',
+        npm: 'linusu',
+        twitter: 'LinusU',
+        email: '[email protected]'
+      }, {
+        name: 'Wes Todd',
+        github: 'wesleytodd',
+        npm: 'wesleytodd',
+        twitter: 'wesleytodd',
+        email: '[email protected]'
+      }]
+    }


Suggested change

teams: {

technicalCommitee: [{

name: 'Doug Wilson',

github: 'dougwilson',

npm: 'dougwilson',

twitter: 'blipsofadoug',

email: '[email protected]'

}, {

name: 'Jonathan Ong',

github: 'jonathanong',

npm: 'jongleberry',

twitter: 'jongleberry',

email: '[email protected]',

avatar: '6e33cc0412b61cc01daac23c8989003c'

}, {

name: 'Jeremiah Senkpiel',

github: 'fishrock123',

npm: 'fishrock123',

twitter: 'fishrock123',

email: '[email protected]'

}, {

name: 'Alex Kocharin',

github: 'rlidwka',

npm: 'rlidwka',

twitter: 'rlidwka',

email: '[email protected]'

}, {

name: 'Linus Unnebäck',

github: 'LinusU',

npm: 'linusu',

twitter: 'LinusU',

email: '[email protected]'

}, {

name: 'Wes Todd',

github: 'wesleytodd',

npm: 'wesleytodd',

twitter: 'wesleytodd',

email: '[email protected]'

}]

}

wesleytodd force-pushed the initial-work branch 2 times, most recently from b43e08e to 820a225 Compare August 15, 2019 22:40

wesleytodd mentioned this pull request Aug 15, 2019

Using GitHub CI/Actions expressjs/discussions#88

Closed

wesleytodd force-pushed the initial-work branch 27 times, most recently from 1de8da9 to 1153084 Compare August 16, 2019 16:50

wesleytodd force-pushed the initial-work branch 19 times, most recently from e1b8b63 to c3bb345 Compare August 26, 2019 02:33

wesleytodd force-pushed the initial-work branch from c3bb345 to cbee72b Compare September 2, 2019 00:07

Configure statusboard

aff7dd4

wesleytodd force-pushed the initial-work branch from cbee72b to aff7dd4 Compare April 22, 2020 19:51

jonchurch reviewed Apr 24, 2020

View reviewed changes

wesleytodd commented Apr 24, 2020

View reviewed changes

wesleytodd mentioned this pull request Apr 29, 2020

Status Board expressjs/discussions#87

Closed

jonchurch requested changes May 20, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Configure statusboard #1

Configure statusboard #1

wesleytodd commented Aug 15, 2019 •

edited

Loading

wesleytodd commented Apr 22, 2020

jonchurch commented Apr 22, 2020 •

edited

Loading

wesleytodd commented Apr 24, 2020

jonchurch Apr 24, 2020 •

edited

Loading

wesleytodd Apr 24, 2020

dougwilson Apr 29, 2020

wesleytodd Apr 29, 2020

wesleytodd Apr 24, 2020

wesleytodd Apr 24, 2020

wesleytodd Apr 24, 2020

dougwilson Apr 29, 2020

wesleytodd Apr 29, 2020

dougwilson Apr 29, 2020

wesleytodd Apr 29, 2020 •

edited

Loading

wesleytodd Apr 24, 2020

jonchurch left a comment

jonchurch May 20, 2020

jonchurch May 20, 2020

jonchurch May 20, 2020

Configure statusboard #1

Are you sure you want to change the base?

Configure statusboard #1

Conversation

wesleytodd commented Aug 15, 2019 • edited Loading

wesleytodd commented Apr 22, 2020

jonchurch commented Apr 22, 2020 • edited Loading

wesleytodd commented Apr 24, 2020

jonchurch Apr 24, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wesleytodd Apr 29, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonchurch left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wesleytodd commented Aug 15, 2019 •

edited

Loading

jonchurch commented Apr 22, 2020 •

edited

Loading

jonchurch Apr 24, 2020 •

edited

Loading

wesleytodd Apr 29, 2020 •

edited

Loading