fix: remove extra quotes from aliased disallowed dependency

ext · Nov 29, 2024 · 553711c · 553711c
1 parent 1bfe367
commit 553711c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/package-json.spec.ts b/src/package-json.spec.ts
@@ -75,7 +75,7 @@ it("should return error if aliased dependency is disallowed", async () => {
 	const { content, ast } = generateAst(pkg);
 	const results = await verifyPackageJson(pkg, ast, "package.json");
 	expect(codeframe(content, results)).toMatchInlineSnapshot(`
-		"ERROR: ""aliased" ("npm:eslint")" should be a devDependency (disallowed-dependency) at package.json
+		"ERROR: "aliased" ("npm:eslint") should be a devDependency (disallowed-dependency) at package.json
 		  18 |   },
 		  19 |   "dependencies": {
 		> 20 |     "aliased": "npm:[email protected]"

diff --git a/src/package-json.ts b/src/package-json.ts
@@ -112,11 +112,11 @@ function verifyDependencies(
 
 		if (isDisallowedDependency(pkg, dependency)) {
 			const { line, column } = jsonLocation(pkgAst, "member", "dependencies", key);
-			const name = key === dependency ? dependency : `"${key}" ("npm:${dependency}")`;
+			const name = key === dependency ? `"${dependency}"` : `"${key}" ("npm:${dependency}")`;
 			messages.push({
 				ruleId: "disallowed-dependency",
 				severity: 2,
-				message: `"${name}" should be a devDependency`,
+				message: `${name} should be a devDependency`,
 				line,
 				column,
 			});