feat: bring library to feature parity with libextism v1.9.0 #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we actually just released 1.9.0 maybe we can take this upgrade opportunity to be sure it's in parity there? or do you want to add the log level stuff via 1.8 first and then another separate update? |
mhmd-azeez
changed the title
|
Good idea, will try to reach parity in this PR |
mhmd-azeez
changed the title
3 tasks
zshipko
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dylibso/xtp/issues/955
This updates the sample apps to use the latest libextism version
Questions:
extism_compiled_plugin_new_error_freefunction (similar toextism_plugin_new_error_free)?Breaking changes toCurrentPlugin.UserData