Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow downloading unzipped binaries #5

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

sgoudham
Copy link

@sgoudham sgoudham commented Oct 6, 2024

Hi 👋,

I'm quite interested in using this action, or more so the @extractions/setup-crate NPM library, to create an action which is able to download binaries which are not gzipped in the release assets. (i.e. catppuccin/whiskers)

From looking through the source code, I see that there's a strong assumption that it's always an extract-able directory. In the interest of time, I quickly mocked up an implementation where it's now assumed that if the download doesn't end with .zip, .tgz or .tar.gz then it is a "naked binary". Then, a temporary directory is created and the downloaded binary is moved into it, allowing the rest of the logic to succeed as normal. I have tested that this implementation works with the existing test suite as demonstrated in my fork's action run.

My preferred approach here would be to split out the logic into 2 separate paths (zipped or unzipped) based on the ending of the file, but that would require a much larger refactor and I was already unsure if this type of change would be accepted. I'd appreciate if you could let me know if you're interested in accepting this type of change before I spend more time on it. I'm more than happy to discuss implementation details going forward (the current code needs a bit of tidy up anyways)

Regardless of whether this PR proceeds, thanks for creating this action and the work you've put into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant