fix: empty last frame on video knob

eye-wave · Nov 26, 2024 · 6e222ff · 6e222ff
1 parent 38c19ac
commit 6e222ff
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
 	"name": "svelte-knobs",
 	"description": "Svelte component library for building customizable knob controls.",
-	"version": "0.3.1",
+	"version": "0.3.2",
 	"repository": {
 		"url": "https://github.com/eye-wave/svelte-knobs"
 	},

diff --git a/src/lib/VideoKnob.svelte b/src/lib/VideoKnob.svelte
@@ -87,7 +87,9 @@
 			let i = -1;
 
 			async function decodeFrame() {
+				if (video.currentTime >= video.duration) return;
 				if (!dctx) throw Error('Failed to create canvas context');
+
 				dctx.clearRect(0, 0, decoderCanvas.width, decoderCanvas.height);
 				dctx.drawImage(video, 0, 0, decoderCanvas.width, decoderCanvas.height);