Skip to content

Commit

Permalink
Fix indentation is README issue list (#1)
Browse files Browse the repository at this point in the history
* Fix indentation is README issue list

* Fix step in PR workflow
  • Loading branch information
eygraber authored Sep 22, 2024
1 parent c3bca37 commit 30778ed
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,6 @@ jobs:

instrumentation_tests:
runs-on: ubuntu-latest
needs: build
timeout-minutes: 70

strategy:
# Allow tests to continue on other devices if they fail on one device.
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ However, there are a couple of issues that Accompanist won't (or can't solve):

1. `rememberPermissionState` breaks Compose Preview

[An issue](https://github.com/google/accompanist/issues/1498) exists, but was closed,
- [An issue](https://github.com/google/accompanist/issues/1498) exists, but was closed,
[delegating the responsibility](https://issuetracker.google.com/issues/267227895) for the fix to the
`findActivity` API. While that might be the correct place to fix this issue, devs have had to deal with this for years,
with no movement towards a fix.

Compose PermissionX solves this by simply making sure `findActivity` isn't called while in a preview.
- Compose PermissionX solves this by simply making sure `findActivity` isn't called while in a preview.

2. The default state of the permission before a request is made
3. Detecting whether a permission was permanently denied
Expand Down

0 comments on commit 30778ed

Please sign in to comment.