Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fs)!: add --only-link option and changed --only-file and --only-d… #518

Closed
wants to merge 2 commits into from
Closed

feat(fs)!: add --only-link option and changed --only-file and --only-d… #518

wants to merge 2 commits into from

Conversation

MartinFillon
Copy link
Contributor

@MartinFillon MartinFillon commented Oct 11, 2023 •
edited
Loading

…ir behaviour

--only-link now only shows links

BREAKING CHANGE:
--only-file now only shows files and links to files --only-dir now only shows directories and links to directories

closes #517
closes #516

@MartinFillon MartinFillon force-pushed the change-only-file-and-only-dir-behaviour branch 2 times, most recently from f6fcecf to 4d9f1f1 Compare October 11, 2023 21:00
@ghost ghost mentioned this pull request Oct 11, 2023
Open
cafkafk
cafkafk requested changes Oct 12, 2023
View reviewed changes
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need the PR summaries to be "!: " (notice the ! for breaking change).

@MartinFillon
Copy link
Contributor Author

my bad

@MartinFillon MartinFillon changed the title feat(fs): add --only-link option and changed --only-file and --only-d… feat(fs)!: add --only-link option and changed --only-file and --only-d… Oct 12, 2023
cafkafk
cafkafk requested changes Oct 13, 2023
View reviewed changes
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good code wise, just needs one nit and completions for zsh, bash, fish, and nushell

src/options/flags.rs Outdated Show resolved Hide resolved
cafkafk
cafkafk requested changes Oct 15, 2023
View reviewed changes
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the ! to the commit summary of the breaking change as well

@MartinFillon MartinFillon force-pushed the change-only-file-and-only-dir-behaviour branch from f3fb4a0 to 3a4bf13 Compare October 15, 2023 17:04
@MartinFillon MartinFillon force-pushed the change-only-file-and-only-dir-behaviour branch 3 times, most recently from d9c76ec to eb7fa12 Compare October 15, 2023 17:08
cafkafk
cafkafk requested changes Oct 16, 2023
View reviewed changes
Copy link
Member

@cafkafk cafkafk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm doing something wrong, but this says the arguments doesn't exist (eza: Unknown argument --only-links)? Maybe the git history got messed up 🤷‍♀️ ? Also this probably needs completions.

@MartinFillon
Copy link
Contributor Author

That is clearly not supposed to happen gonna investigate

@MartinFillon MartinFillon force-pushed the change-only-file-and-only-dir-behaviour branch from 4f58415 to 3a054e6 Compare October 16, 2023 18:33
@MartinFillon
Copy link
Contributor Author

Ok in fact I was dumb, but that is also due to the parser being so great

@MartinFillon MartinFillon force-pushed the change-only-file-and-only-dir-behaviour branch from 3a054e6 to db69a60 Compare October 16, 2023 18:49
@MartinFillon
Copy link
Contributor Author

Okay I can't seem to find the way to run the command TRYCMD=overwrite cargo test in nix could you help me with that @cafkafk ?

@MartinFillon MartinFillon force-pushed the change-only-file-and-only-dir-behaviour branch 5 times, most recently from 8c0671c to ffe1335 Compare October 16, 2023 19:53
@cafkafk
Copy link
Member

cafkafk commented Oct 17, 2023

Okay I can't seem to find the way to run the command TRYCMD=overwrite cargo test in nix could you help me with that @cafkafk ?

You can't currently do that, but we have just idump that should update the tests

@MartinFillon
Copy link
Contributor Author

fixed the last one lasting

@MartinFillon MartinFillon force-pushed the change-only-file-and-only-dir-behaviour branch from a6b3b07 to 69a3f09 Compare December 4, 2023 22:37
PThorpe92
PThorpe92 previously approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@PThorpe92 PThorpe92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, briefly tested and it works 👍

@cafkafk cafkafk force-pushed the change-only-file-and-only-dir-behaviour branch 2 times, most recently from 8a1a9e9 to 354a611 Compare December 5, 2023 11:22
cafkafk
cafkafk requested changes Dec 5, 2023
View reviewed changes
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked on latest version, all work except:

cargo run -- -l --only-dirs --only-links
cargo run -- -l --only-files --only-links

They also show dirs and files that aren't links

@PThorpe92
Copy link
Member

Just checked on latest version, all work except:

cargo run -- -l --only-dirs --only-links
cargo run -- -l --only-files --only-links

They also show dirs and files that aren't links

😅 lol good catch I didn't test them together

@MartinFillon MartinFillon force-pushed the change-only-file-and-only-dir-behaviour branch 2 times, most recently from e888ae6 to 524dd4a Compare December 9, 2023 22:56
@MartinFillon MartinFillon force-pushed the change-only-file-and-only-dir-behaviour branch from 524dd4a to ba883c6 Compare December 9, 2023 23:11
@MartinFillon MartinFillon force-pushed the change-only-file-and-only-dir-behaviour branch 2 times, most recently from 044d52e to 2c35ba4 Compare December 10, 2023 19:46
@MartinFillon MartinFillon force-pushed the change-only-file-and-only-dir-behaviour branch 2 times, most recently from 3e42946 to 2bafa41 Compare January 22, 2024 17:42
@MartinFillon
Copy link
Contributor Author

made some changes @cafkafk if you wanna see

@MartinFillon MartinFillon force-pushed the change-only-file-and-only-dir-behaviour branch from 2bafa41 to 0d93a53 Compare January 24, 2024 12:40
cafkafk
cafkafk requested changes Mar 3, 2024
View reviewed changes
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be some conflicts, after fix I'll take a look 👍

@MartinFillon
Copy link
Contributor Author

Gonna fix all of that when I have time

@MartinFillon MartinFillon force-pushed the change-only-file-and-only-dir-behaviour branch from 0d93a53 to 43e370a Compare March 4, 2024 14:03
@MartinFillon MartinFillon force-pushed the change-only-file-and-only-dir-behaviour branch from cdee0d9 to 3fc87d6 Compare March 27, 2024 07:23
@MartinFillon
feat(fs)!: add --only-link option and changed --only-file and --only-…
cb9ba6b 
…dir behaviour

--only-link now only shows links

Adeed --only-links option
Updated tests

BREAKING CHANGE:
--only-file now only shows files and links to files
--only-dir now only shows directories and links to directories
@MartinFillon
fix: tests not working
f410e59
@MartinFillon MartinFillon force-pushed the change-only-file-and-only-dir-behaviour branch from 3fc87d6 to f410e59 Compare June 5, 2024 06:28
@MartinFillon MartinFillon mentioned this pull request Jun 18, 2024
Merged
@MartinFillon
Copy link
Contributor Author

Superseeded by #1028

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PThorpe92 PThorpe92 PThorpe92 left review comments

@cafkafk cafkafk Awaiting requested review from cafkafk cafkafk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Eza Pull-Requests
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add --only-links feat: include symlinks in --only-files
3 participants
@MartinFillon @cafkafk @PThorpe92