Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7579:Richtext: Rows are added to ezurl_object_link on every save #242

Open
wants to merge 2 commits into
base: 2.3
Choose a base branch
from

Conversation

vidarl
Copy link
Member

@vidarl vidarl commented Feb 13, 2024

Question Answer
JIRA issue IBX-7579
Bug yes
New feature no
Target version 2.3
BC breaks no
Tests pass yes
Doc needed maybe

If the same link is referenced to several times in the same richtext field, there is a mechanism for preventing it from being added to the ezurl_object_link table multiple times. However, it doesn't take into account that draft can be saved multiple times.

Corresponding kernel PR : ezsystems/ezplatform-kernel#402

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@vidarl
Copy link
Member Author

vidarl commented Apr 4, 2024

@webhdx : Why is rebase needed? branch is based on 314fd1f which is still HEAD of 2.3 branch..

@webhdx
Copy link
Contributor

webhdx commented Apr 8, 2024

Because of the temporary commit. It's easy to overlook it and merge the PR.

@vidarl vidarl force-pushed the ibx-7579_rows_are_added_to_ezurl_object_link_on_every_save_by_richtext branch from 403de80 to e6f6d4e Compare April 9, 2024 07:04
@vidarl
Copy link
Member Author

vidarl commented Apr 12, 2024

@webhdx : tmp commits removed

@vidarl vidarl force-pushed the ibx-7579_rows_are_added_to_ezurl_object_link_on_every_save_by_richtext branch from 86642f2 to 0a3c480 Compare June 19, 2024 11:51
@vidarl vidarl requested a review from alongosz June 20, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants