Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docker] Docker workflow upgrade #197

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

fchris82
Copy link

It is better way when the developer can use custom .env, and can change eg. the HTTP_HOST and HTTP_PORT.
For example I am using the 8080 port by other program and I prefer the unique domain per project because of cookies and remembered usernames/passwords.

So I want to use:

HTTP_PORT=80
HTTP_HOST=concrate-ez-project.loc

- Rename .env to .env.dist
- Add host and port support
- Update the README.md
@fchris82 fchris82 changed the title Docker workflow upgrade [Docker] Docker workflow upgrade Aug 15, 2017
@andrerom
Copy link
Contributor

andrerom commented Aug 15, 2017

Hi @fchris82,

nice contribution!

Things to note:

  • The docker setup is undergoing some changes atm so we'll look at this once those things have been finalized and merged (EZP-27788: Update and cleanup docker config for Docker 17.06 features #192 and [WIP] Adding support for docker stack ezplatform-ee-demo#33), so as your are still amending this mark it as [WIP], once it's ready for review remove that & add a issue link to jira
  • Regarding the added script, if we are to add this we would probably use make file (like Symfony Flex is) to start to cover several use cases where we could benefit from some scripting
  • Be aware the docker setup in this repo is mainly for QA/Automated testing needs at this stage as well as set of examples of setup, for pure developer project use we rather promote usage of eZ Launchpad which already lets you set different port numbers per project and more

I prefer the unique domain per project because of cookies and remembered usernames/passwords.

good point

@fchris82
Copy link
Author

I have been trying the Launchpad. I like the concept, I wanted to similar :) I'm reviewing and when I miss something, I will make pull request there or jira ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants