Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipes created by initial composer install #438

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emodric
Copy link
Contributor

@emodric emodric commented Jul 30, 2019

Symfony recomends storing the symfony.lock file in the repo for your projects.

To reduce friction for new installs, this adds the recipes installed by the initial composer install as well as adding symfony.lock to the repo so users don't have to touch .gitignore when they need to store the lock file.

@andrerom
Copy link
Contributor

andrerom commented Jul 30, 2019

hmm, but do we want the lock in our repo?

Atm we don't keep locks in product repos, but when making tags we swap this so projects do keep them: https://github.com/ezsystems/ezplatform/blob/master/bin/.ci/make_tag.sh#L86-L87

@andrerom
Copy link
Contributor

andrerom commented Jul 30, 2019

Reminds me that we should consider adding .gitattribute for certain things also: https://medium.com/@pablorsk/be-a-git-ninja-the-gitattributes-file-e58c07c9e915

but that goes for more then just master

@emodric
Copy link
Contributor Author

emodric commented Jul 30, 2019

Hm, that does solve the .gitignore issue, but it still would cause readding the default assets:install command from the recipe if we would merge #437.

Related issue on symfony/recipes: symfony/recipes#631

Also, Sylius does keep symfony.lock in their repo: https://github.com/sylius/sylius

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants