Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Add passthrough kwargs for torch.load #13

Merged
merged 3 commits into from
Sep 11, 2024
Merged

[API] Add passthrough kwargs for torch.load #13

merged 3 commits into from
Sep 11, 2024

Conversation

scottclowe
Copy link
Collaborator

@scottclowe scottclowe commented Sep 11, 2024 •
edited
Loading

  • Support arbitrary kwargs being passed from load_latest_checkpoint to torch.load
  • Change the default value to torch.load of weights_only=True

@scottclowe
[ENH] Add handling of passthrough kwargs to torch.load
0718126 
Support passing **kwargs from load_latest_checkpoint to torch.load.
@scottclowe scottclowe requested a review from f-dangel September 11, 2024 15:21
@scottclowe
[API] Change to weights_only=True by default to torch.load
e52a57e 
This prevents unpickling dangerous contents from the checkpoint.
@scottclowe scottclowe force-pushed the api_passthrough-torch-load branch from b96a312 to e52a57e Compare September 11, 2024 15:22
f-dangel
f-dangel reviewed Sep 11, 2024
View reviewed changes
Copy link
Owner

@f-dangel f-dangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@f-dangel f-dangel merged commit 9b2abfb into main Sep 11, 2024
14 checks passed
@f-dangel f-dangel deleted the api_passthrough-torch-load branch September 11, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-dangel f-dangel f-dangel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottclowe @f-dangel