Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Walkthrough #9

Merged
merged 33 commits into from
Sep 11, 2024
Merged

[DRAFT] Walkthrough #9

merged 33 commits into from
Sep 11, 2024

Conversation

f-dangel
Copy link
Owner

@f-dangel f-dangel commented Sep 10, 2024

I wrote a rough scaffold with instructions that a reader should be able to execute.
Please try building the docs locally (mkdocs serve), then navigate to the 'Walkthrough Example' section and try running the commands.

I am sure there will be bugs. Let's start a list:

  • FIXED: Always return tuple in load_latest_checkpoint
  • BUG: At the moment, a SLURM job does not shut down after finishing a run, but instead requeues itself. I believe this must be related to some refactoring in the launch.sh script.

Additional TODOs:

  • Complete content of the walkthrough (some text and screenshots missing)
  • One polishing pass

@f-dangel f-dangel requested a review from scottclowe September 10, 2024 02:46
@scottclowe
Copy link
Collaborator

Great, will check it out!

@scottclowe
Copy link
Collaborator

I think we have the bugs fixed now, so it would be good to merge this in soon.

I'd like it if the references to methods, e.g. checkpointer.step were linked rather than plain code, but I don't know how to set that up in mkdocs.

@f-dangel f-dangel merged commit 0fb6333 into main Sep 11, 2024
14 checks passed
@f-dangel f-dangel deleted the walkthrough branch September 11, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants