Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] 토론 피드 상세 모달 읽기 전용 UI 구현 #27

Merged
merged 16 commits into from
Nov 5, 2024

Conversation

seongjin2427
Copy link
Collaborator

Pull Request 요약

PR에 대한 내용을 작성해주세요.

토론 피드 상세 모달 읽기 전용 UI를 구현합니다.


작업 내용

작업 내용에 대해서 작성해주세요.

  • ReadOnlyDebateFeed - 토론 피드 읽기 전용 UI를 불러옵니다. (브라우저 주소창 쿼리스트링에 cf키에 대한 값이 존재하면 렌더링됨)
  • DebateContent - 토론 피드 내용 중 찬성/반대를 렌더링 하는 컴포넌트
  • 그 외 FeedWrapper, FeedTextContent, FeedLikeBox, FeedCommentWithInput 등 피드 관련 재사용된 컴포넌트들에 대해 일부 수정을 하였습니다.

참고 사항

참고 사항이 있다면 첨부해주세요.

  • FeedCommentList1st, 2nd, 3rd 칩은 서버 연동 시 구현 예정입니다.

관련 이슈

closing할 이슈 번호를 작성해주세요.


- FeedWrapper depends on whether there is pathname value "p" or not
- If pathname "p" value of browser navigation is existed, FeedWrapper render children props
- The folder name included "@" caused error when committing
- The folder name to start "@" means slot router
- FeedWrapper depends on whether or not browser navigation has value of key "f"
- ReadOnlyCommonFeed is only rendering from props information about common feed
- FeedTextContent is rendering feed information (profile, content, username etc.)
- not included server request logic
- added height, maxHeight props at Modal Component
- update useAutoResizeTextArea hook (not use row count, use scrollHeight)
@seongjin2427 seongjin2427 added the feat 구현, 개선 사항에 관련된 이슈입니다. label Nov 4, 2024
@seongjin2427 seongjin2427 self-assigned this Nov 4, 2024
@seongjin2427 seongjin2427 requested a review from lee1nna November 4, 2024 13:32
Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for prostargram failed.

Name Link
🔨 Latest commit b8e7937
🔍 Latest deploy log https://app.netlify.com/sites/prostargram/deploys/672a11ab6ca030000855cfec

Copy link
Collaborator

@lee1nna lee1nna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !

@seongjin2427 seongjin2427 merged commit 2f3076e into develop Nov 5, 2024
1 check passed
Copy link

sonarqubecloud bot commented Nov 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 구현, 개선 사항에 관련된 이슈입니다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

토론 피드 상세 읽기 모달 UI 구현
2 participants