-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] 토론 피드 상세 모달 읽기 전용 UI 구현 #27
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- FeedWrapper depends on whether there is pathname value "p" or not - If pathname "p" value of browser navigation is existed, FeedWrapper render children props
- The folder name included "@" caused error when committing - The folder name to start "@" means slot router
- FeedWrapper depends on whether or not browser navigation has value of key "f" - ReadOnlyCommonFeed is only rendering from props information about common feed - FeedTextContent is rendering feed information (profile, content, username etc.)
…tContent Component
- not included server request logic
…ontend into feature/common-feed-read-modal
- added height, maxHeight props at Modal Component
- update useAutoResizeTextArea hook (not use row count, use scrollHeight)
❌ Deploy Preview for prostargram failed.
|
lee1nna
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다 !
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request 요약
토론 피드 상세 모달 읽기 전용 UI를 구현합니다.
작업 내용
ReadOnlyDebateFeed
- 토론 피드 읽기 전용 UI를 불러옵니다. (브라우저 주소창 쿼리스트링에cf
키에 대한 값이 존재하면 렌더링됨)DebateContent
- 토론 피드 내용 중 찬성/반대를 렌더링 하는 컴포넌트FeedWrapper
,FeedTextContent
,FeedLikeBox
,FeedCommentWithInput
등 피드 관련 재사용된 컴포넌트들에 대해 일부 수정을 하였습니다.참고 사항
FeedCommentList
의1st
,2nd
,3rd
칩은 서버 연동 시 구현 예정입니다.관련 이슈