Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] 회원가입 페이지 API 연동 (추가 정보 페이지 미 포함) #36

Merged
merged 15 commits into from
Dec 7, 2024
Merged

[feat] 회원가입 페이지 API 연동 (추가 정보 페이지 미 포함) #36

merged 15 commits into from
Dec 7, 2024

Conversation

seongjin2427
Copy link
Collaborator

@seongjin2427 seongjin2427 commented Dec 6, 2024 •
edited
Loading

Pull Request 요약

PR에 대한 내용을 작성해주세요.

자체 회원가입 페이지의 서버 요청 API를 연동한 PR입니다.


작업 내용

작업 내용에 대해서 작성해주세요.

  • 자체 회원가입 페이지 서버 요청 API 연동

참고 사항

참고 사항이 있다면 첨부해주세요.

  • 회원가입 완료 후 추가 정보 입력 페이지로 이동되나, 추가 정보 입력페이지는 서버 로직과 연동이 되어 있지 않습니다.
  • 추가 정보 입력 페이지는 다른 PR에서 AP 연동 진행토록 하겠습니다.

관련 이슈

closing할 이슈 번호를 작성해주세요.

@seongjin2427
[feat] initial setting up for Tanstack-query
228a0f8
@seongjin2427
[style] added fill props "gray" of ProfileEditButton Component
a834e53
@seongjin2427
Merge branch 'develop' of https://github.com/f-lab-edu/Prostargram-fr…
4d66fb0 
…ontend into feature/my-page-connect-api
@seongjin2427
[feat] added useTimer hook
78e8bf6
@seongjin2427
Merge branch 'develop' of https://github.com/f-lab-edu/Prostargram-fr…
1d15de0 
…ontend into feature/connect-api-sign-up
@seongjin2427
[feat] added FieldTimerButton in Field Component
127bf8a
@seongjin2427
[feat] update for email confirmation retry in Field Component and use…
06d6904 
…SignUpState logic
@seongjin2427
[feat] update Field Component Naming
7a31bea
@seongjin2427
[feat] complete first sign up step page
22d4cd3
@seongjin2427
[feat] added logic of request server api for additional Info page
34756ab
@seongjin2427
[feat] modify error message for username duplicate
054a84e
@seongjin2427
[refact] refactored sign up page (included github sign up)
f97a7e0
@seongjin2427
[feat] add login login after being successful sign up step
dbfeabc
@seongjin2427
[feat] added login login after being successfule sign up step at Gith…
f7d2b2e 
…ub page
@seongjin2427 seongjin2427 added the feat 구현, 개선 사항에 관련된 이슈입니다. label Dec 6, 2024
@seongjin2427 seongjin2427 requested a review from lee1nna December 6, 2024 06:13
@seongjin2427 seongjin2427 self-assigned this Dec 6, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 6, 2024 •
edited
Loading

❌ Deploy Preview for prostargram failed.

Name Link
🔨 Latest commit 581c7f6
🔍 Latest deploy log https://app.netlify.com/sites/prostargram/deploys/675296c2429b8b0008c58e10

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
24.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

lee1nna
lee1nna approved these changes Dec 7, 2024
View reviewed changes
Copy link
Collaborator

@lee1nna lee1nna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 👍

@seongjin2427 seongjin2427 merged commit 5e59603 into develop Dec 7, 2024
1 of 6 checks passed
@seongjin2427 seongjin2427 deleted the feature/connect-sign-up-api branch December 7, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lee1nna lee1nna lee1nna approved these changes

Assignees

@seongjin2427 seongjin2427

Labels
feat 구현, 개선 사항에 관련된 이슈입니다.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

회원가입 페이지(자체) 구현
2 participants
@seongjin2427 @lee1nna