[#3] controller, dto 생성, Test 코드 작성 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-lyan
reviewed
Dec 11, 2024
api/build.gradle
Outdated
| @@ -10,4 +11,5 @@ dependencies { | |||
| implementation 'org.springframework.boot:spring-boot-starter' | |||
| implementation 'org.springframework.boot:spring-boot-starter-web' | |||
| testImplementation 'org.springframework.boot:spring-boot-starter-test' | |||
| testImplementation 'org.apache.ant:ant:1.10.13' | |||
f-lab-lyan
reviewed
Dec 11, 2024
|
|
||
| @PutMapping("/settings") | ||
| public String updateAlertSetings(@RequestBody AlertSettingsDto settings){ | ||
| return "updated setting"; |
There was a problem hiding this comment.
업데이트된 AlertSettings를 보여주는게 좋지 않을까요?
f-lab-lyan
reviewed
Dec 11, 2024
|
|
||
| @PostMapping | ||
| public String createPost(@RequestBody PostDto post) { | ||
| return "게시글 생성 : " + post.getTitle(); |
There was a problem hiding this comment.
아웃풋은 되도록이면, 구조체로 보내는 것이 좋은 것 같습니다. title만 보낼 것이어도, json형태로 보내는 것이 클라이언트에서 사용하기 편하지 않을까 싶네요.
f-lab-lyan
reviewed
Dec 11, 2024
| public class AlertController { | ||
|
|
||
| @GetMapping("/settings") | ||
| public AlertSettingsDto getAlertSettings() { |
There was a problem hiding this comment.
AlertSettings가 여러개 인 경우가 더 일반적이지 않을까요?
f-lab-lyan
reviewed
Dec 11, 2024
| } | ||
|
|
||
| @PutMapping("/settings") | ||
| public String updateAlertSetings(@RequestBody AlertSettingsDto settings){ |
There was a problem hiding this comment.
하나의 alertSettings를 지정하기 위한 key나 unique값이 필요하지 않을까요? 어떤 alertSettings를 바꾸고 싶은지에 대해서 ...
f-lab-lyan
reviewed
Dec 11, 2024
|
|
||
| @RestController | ||
| @RequestMapping("/api/posts") | ||
| public class CommunityController { |
f-lab-lyan
reviewed
Dec 11, 2024
| public class TransactionController { | ||
|
|
||
| @GetMapping("/list") | ||
| public List<TransactionDto> getTransactions(){ |
f-lab-lyan
reviewed
Dec 11, 2024
|
|
||
| @RestController | ||
| @RequestMapping("/api/alerts") | ||
| public class AlertController { |
f-lab-lyan
reviewed
Dec 11, 2024
| return userDto; | ||
| } | ||
|
|
||
| @GetMapping("/me") |
There was a problem hiding this comment.
Suggested change
| @GetMapping("/me") | |
| @GetMapping |
f-lab-lyan
reviewed
Dec 11, 2024
| import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.put; | ||
| import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.*; | ||
|
|
||
| @WebMvcTest(controllers = AlertController.class) |
f-lab-lyan
reviewed
Dec 11, 2024
| public class AlertControllerTest { | ||
|
|
||
| @Autowired | ||
| MockMvc mockMvc; |
f-lab-lyan
reviewed
Dec 11, 2024
| .content(userJson)) | ||
| .andExpect(status().isOk()) | ||
| .andExpect(jsonPath("$.email").value("[email protected]")) | ||
| .andExpect(jsonPath("$.username").value("Test")); |
There was a problem hiding this comment.
포함되어야하는 필드 이외에 다른 필드가 없는지는 어떻게 테스트할 수 있을까요?
f-lab-lyan
reviewed
Dec 11, 2024
|
|
||
| @Test | ||
| void createPost() throws Exception { | ||
| PostDto post = new PostDto(3, "Post1", "post1"); |
There was a problem hiding this comment.
createPost인데 PostDto에 id가 있는 것이 좀 이상한 것 같아요. :-)
f-lab-lyan
reviewed
Dec 11, 2024
| } | ||
|
|
||
| @PostMapping("/login") | ||
| public UserDto loginUser(@RequestBody UserDto userDto) { |
|
f-lab-lyan
reviewed
Dec 17, 2024
| @RestController | ||
| @RequestMapping("/api/posts") | ||
| public class PostController { | ||
| private List<PostDto> posts = new ArrayList<>(); |
There was a problem hiding this comment.
중요한건 아니지만, ArrayList는 Thread-safe한가요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현사항