[#3] 도서 목록/검색 화면 개발 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
virere
reviewed
Jan 21, 2025
| book: Book; | ||
| } | ||
|
|
||
| export default function BookCard({ book }: BookCardProps) { |
There was a problem hiding this comment.
이 컴포넌트는 pure 하기 때문에 과감하게 memo 한 결과를 export 해도 됨
| } | ||
|
|
||
| export default function BookSearch({ initialSearchTerm = '' }: BookSearchProps) { | ||
| const [searchTerm, setSearchTerm] = useState(initialSearchTerm); |
Comment on lines
+29
to
+36
| const baseSearchParams = { | ||
| MaxResults: '10', | ||
| start: '1', | ||
| SearchTarget: 'Book', | ||
| Cover: 'Big', | ||
| output: 'js', | ||
| Version: '20131101', | ||
| }; |
There was a problem hiding this comment.
Suggested change
| const baseSearchParams = { | |
| MaxResults: '10', | |
| start: '1', | |
| SearchTarget: 'Book', | |
| Cover: 'Big', | |
| output: 'js', | |
| Version: '20131101', | |
| }; | |
| const baseSearchParams = { | |
| MaxResults: '10', | |
| start: '1', | |
| SearchTarget: 'Book', | |
| Cover: 'Big', | |
| output: 'js', | |
| Version: '20131101', | |
| } as const; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업사항
기타
ky를 적용했습니다.화면 이미지
Desktop
Tablet
Mobile