Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main page test #13

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Main page test #13

wants to merge 3 commits into from

Conversation

EUNSUN23
Copy link
Collaborator

๐ŸŽ‹ ์ž‘์—…์ค‘์ธ ๋ธŒ๋žœ์น˜

Main page test


๐Ÿ’ก ์ž‘์—… ๋‚ด์šฉ

ํ’€ ๋ฆฌํ€˜์ŠคํŠธ์— ๋Œ€ํ•œ ๊ฐ„๋žตํ•œ ์„ค๋ช…์„ ์—ฌ๊ธฐ์— ์ž…๋ ฅํ•ด์ฃผ์„ธ์š”

1. msw ์…‹์—… & api mockup

2. ๋ฉ”์ธํŽ˜์ด์ง€ ํ…Œ์ŠคํŠธ์ฝ”๋“œ ์ถ”๊ฐ€


๐Ÿ”‘ ๋ณ€๊ฒฝ๋œ ์‚ฌํ•ญ

๋ณ€๊ฒฝ๋œ ํŒŒ์ผ๊ณผ ๊ทธ์— ๋Œ€ํ•œ ๊ฐ„๋žตํ•œ ์„ค๋ช…์„ ๋‚˜์—ดํ•ด์ฃผ์„ธ์š”.

1. msw ์…‹์—… & api mockup


b03f8e4, a16811f
  • ํ…Œ์ŠคํŠธ์šฉ api mockup ์œ„ํ•ด msw๋ฅผ ์„ค์น˜ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ๋ฉ”์ธํŽ˜์ด์ง€ api mockup๊ณผ ํ…Œ์ŠคํŠธ ๋ฐ์ดํ„ฐ๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

2. ๋ฉ”์ธํŽ˜์ด์ง€ ํ…Œ์ŠคํŠธ์ฝ”๋“œ ์ถ”๊ฐ€


9d1fb92

  • ๋ฉ”์ธํŽ˜์ด์ง€์˜ ํƒญ ๋ Œ๋”๋ง & ์ƒํ˜ธ์ž‘์šฉ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ํ…Œ์ŠคํŠธ ์ž‘์„ฑ์„ ์œ„ํ•ด ์ ‘๊ทผ์„ฑ ๋“ฑ ์†Œ์Šค ์ผ๋ถ€๋ฅผ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

โœ๏ธ ๋น„๊ณ  (์„ ํƒ)

๋‹ค๋ฅธ ๋ฆฌ๋ทฐ์–ด ๋˜๋Š” ํŒ€์›์—๊ฒŒ ์ „๋‹ฌํ•˜๊ณ  ์‹ถ์€ ์ถ”๊ฐ€ ์ •๋ณด๋‚˜ ์š”์ฒญ์‚ฌํ•ญ์„ ์—ฌ๊ธฐ์— ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”.


โœ… Todo ๋ชฉ๋ก (์„ ํƒ)

ํ•„์š”ํ•œ ๊ฒฝ์šฐ ์ถ”๊ฐ€ ์ž‘์—…์ด๋‚˜ ๋ณ€๊ฒฝ ์‚ฌํ•ญ์„ ์ถ”์ ํ•˜๊ธฐ ์œ„ํ•ด Todo ๋ชฉ๋ก์„ ์—ฌ๊ธฐ์— ์ถ”๊ฐ€ํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.

  • ์•”์†กํŽ˜์ด์ง€ ์ž‘์—… & ํ…Œ์ŠคํŠธ์ฝ”๋“œ ์ž‘์„ฑ

@EUNSUN23 EUNSUN23 requested a review from f-lab-ash March 11, 2025 14:49
@EUNSUN23 EUNSUN23 self-assigned this Mar 11, 2025
Copy link

@f-lab-ash f-lab-ash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๐Ÿ‘

const { sub_series_opt, series_code } = data;

const hasSubSeries = sub_series_opt === 'Y';

const {
data: subSeriesData,
isPending: isSubSeriesPending,
isLoading: isSubSeriesPending,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ask;
isPending๊ณผ isLoading์˜ ์ฐจ์ด๋Š” ํ™•์ธํ•ด๋ณด์…จ์„๊นŒ์š”?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋„ต, ๊ธฐ์กด์—๋Š” tabํด๋ฆญ์ด ์•ˆ๋˜๋ฉด SeriesContents๋ฅผ ์•„์˜ˆ ๋ Œ๋”๋ง ์•ˆ๋˜๊ฒŒ ํ–ˆ๋Š”๋ฐ, ํ…Œ์ŠคํŠธ ์ž‘์„ฑ์„ ํ•˜๋‹ค๋ณด๋‹ˆ SeriesContents๊ฐ€ ๊ณ„์† ๋”์ƒ์— ์žˆ์–ด์•ผ ํ•ด์„œ, ๋‚ด๋ถ€์—์„œ ํ‘œ์‹œํ•˜๋Š” loader๊ฐ€ ์‹ค์ œ๋กœ ๋ฐ์ดํ„ฐ fetch๋ฅผ ํ•  ๋•Œ์— ํ‘œ์‹œ๋˜๊ฒŒ๋”ํ•˜๊ฒŒ ํ•˜๋ ค๊ณ  isPending -> isLoading์œผ๋กœ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

@EUNSUN23 EUNSUN23 requested a review from f-lab-ash March 12, 2025 06:47
{isTabOpen && <SeriesContents contentsId={contentsId} data={data} />}
{
<SeriesContents
contentsId={contentsId}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ œ๊ฐ€ ๋Šฆ๊ฒŒ ๋ฐœ๊ฒฌํ–ˆ๋„ค์š”.
id์˜ ๊ฒฝ์šฐ ๋‹จ์ˆ˜ํ˜•์œผ๋กœ ์‚ฌ์šฉํ•˜๋Š” ๊ฒƒ์ด ์ผ๋ฐ˜์ ์ž…๋‹ˆ๋‹ค.
contentsId -> contentId

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants