-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main page test #13
base: main
Are you sure you want to change the base?
Main page test #13
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๐
const { sub_series_opt, series_code } = data; | ||
|
||
const hasSubSeries = sub_series_opt === 'Y'; | ||
|
||
const { | ||
data: subSeriesData, | ||
isPending: isSubSeriesPending, | ||
isLoading: isSubSeriesPending, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ask;
isPending๊ณผ isLoading์ ์ฐจ์ด๋ ํ์ธํด๋ณด์
จ์๊น์?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๋ต, ๊ธฐ์กด์๋ tabํด๋ฆญ์ด ์๋๋ฉด SeriesContents๋ฅผ ์์ ๋ ๋๋ง ์๋๊ฒ ํ๋๋ฐ, ํ ์คํธ ์์ฑ์ ํ๋ค๋ณด๋ SeriesContents๊ฐ ๊ณ์ ๋์์ ์์ด์ผ ํด์, ๋ด๋ถ์์ ํ์ํ๋ loader๊ฐ ์ค์ ๋ก ๋ฐ์ดํฐ fetch๋ฅผ ํ ๋์ ํ์๋๊ฒ๋ํ๊ฒ ํ๋ ค๊ณ isPending -> isLoading์ผ๋ก ์์ ํ์ต๋๋ค.
{isTabOpen && <SeriesContents contentsId={contentsId} data={data} />} | ||
{ | ||
<SeriesContents | ||
contentsId={contentsId} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ ๊ฐ ๋ฆ๊ฒ ๋ฐ๊ฒฌํ๋ค์.
id์ ๊ฒฝ์ฐ ๋จ์ํ์ผ๋ก ์ฌ์ฉํ๋ ๊ฒ์ด ์ผ๋ฐ์ ์
๋๋ค.
contentsId -> contentId
๐ ์์ ์ค์ธ ๋ธ๋์น
Main page test
๐ก ์์ ๋ด์ฉ
1. msw ์ ์ & api mockup
2. ๋ฉ์ธํ์ด์ง ํ ์คํธ์ฝ๋ ์ถ๊ฐ
๐ ๋ณ๊ฒฝ๋ ์ฌํญ
1. msw ์ ์ & api mockup
b03f8e4, a16811f
2. ๋ฉ์ธํ์ด์ง ํ ์คํธ์ฝ๋ ์ถ๊ฐ
9d1fb92
โ๏ธ ๋น๊ณ (์ ํ)
โ Todo ๋ชฉ๋ก (์ ํ)