Remove handling of stopName via deep link

f-lab-edu · Jan 15, 2025 · 5fe1c6c · 5fe1c6c
1 parent 66c89e1
commit 5fe1c6c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 11 deletions.
diff --git a/feature/stopdetail/src/main/java/com/chaeny/busoda/stopdetail/StopDetailViewModel.kt b/feature/stopdetail/src/main/java/com/chaeny/busoda/stopdetail/StopDetailViewModel.kt
@@ -13,11 +13,9 @@ internal class StopDetailViewModel(savedStateHandle: SavedStateHandle) : ViewMod
     private val dummyData = MutableLiveData<List<Bus>>()
     private val isLoadingData = MutableLiveData<Boolean>()
     private val stopIdData = MutableLiveData<String>(savedStateHandle.get(BUS_STOP_ID))
-    private val stopNameData = MutableLiveData<String>(savedStateHandle.get(BUS_STOP_NAME))
     val busInfos: LiveData<List<Bus>> = dummyData
     val isLoading: LiveData<Boolean> = isLoadingData
     val stopId: LiveData<String> = stopIdData
-    val stopName: LiveData<String> = stopNameData
 
     private val dummyDataMapCreators: Map<String, List<Bus>> = mapOf(
         "16206" to listOf(
@@ -142,6 +140,5 @@ internal class StopDetailViewModel(savedStateHandle: SavedStateHandle) : ViewMod
 
     companion object {
         private const val BUS_STOP_ID = "stopId"
-        private const val BUS_STOP_NAME = "stopName"
     }
 }
diff --git a/feature/stopdetail/src/main/res/navigation/stopdetail_nav_graph.xml b/feature/stopdetail/src/main/res/navigation/stopdetail_nav_graph.xml
@@ -11,15 +11,11 @@
         tools:layout="@layout/fragment_stop_detail">
 
         <deepLink
-            app:uri="android-app://com.chaeny.busoda/fragment_stop_detail?stopId={stopId}&amp;stopName={stopName}" />
+            app:uri="android-app://com.chaeny.busoda/fragment_stop_detail?stopId={stopId}" />
 
         <argument
             android:name="stopId"
             app:argType="string" />
-
-        <argument
-            android:name="stopName"
-            app:argType="string" />
     </fragment>
 
 </navigation>
diff --git a/feature/stoplist/src/main/java/com/chaeny/busoda/stoplist/StopListAdapter.kt b/feature/stoplist/src/main/java/com/chaeny/busoda/stoplist/StopListAdapter.kt
@@ -28,8 +28,8 @@ internal class StopListAdapter : ListAdapter<BusStop, StopListAdapter.BusStopVie
 
     class BusStopViewHolder(private val binding: ListItemStopBinding) : RecyclerView.ViewHolder(binding.root) {
 
-        private fun navigateToStopDetail(stopId: String, stopName: String) {
-            val uri = "android-app://com.chaeny.busoda/fragment_stop_detail?stopId=$stopId&stopName=$stopName"
+        private fun navigateToStopDetail(stopId: String) {
+            val uri = "android-app://com.chaeny.busoda/fragment_stop_detail?stopId=$stopId"
             val request = NavDeepLinkRequest.Builder
                 .fromUri(uri.toUri())
                 .build()
@@ -46,7 +46,7 @@ internal class StopListAdapter : ListAdapter<BusStop, StopListAdapter.BusStopVie
                 textStopName.text = stopData.stopName
                 textNextStop.text = stopData.formatNextStopName()
                 root.setOnClickListener {
-                    navigateToStopDetail(stopData.stopId, stopData.stopName)
+                    navigateToStopDetail(stopData.stopId)
                 }
             }
         }