[CT-3-3] 차트게임 기능 - data 레이어 - repository #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nosorae
changed the title
data/src/main/java/com/yessorae/data/repository/ChartGameRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
data/src/main/java/com/yessorae/data/repository/ChartGameRepositoryImpl.kt
Show resolved
Hide resolved
…/ct-3-chart-game-data-repository-impl
…twork-source [CT-3-1] 차트게임 기능 - data 레이어 - network
Base automatically changed from
feature/ct-3-chart-game-data-local-source
to
feature/ct-3-chart-game-data-network-source
May 20, 2024 14:40
|
슬랙에서 질문 답변해주신 withTransaction을 적용했습니다. |
|
아마 23일까지는 리뷰 반영할 수 있을 것 같습니다.
|
…ository-impl' into feature/ct-3-chart-game-data-repository-impl
|
f-lab-nathan
approved these changes
May 24, 2024
| import androidx.room.withTransaction | ||
| import javax.inject.Inject | ||
|
|
||
| class ChartTrainerDatabaseTransactionHelper @Inject constructor( |
There was a problem hiding this comment.
nit; helper 대신 executor는 어떨까요?
| import javax.inject.Inject | ||
| import kotlinx.coroutines.flow.Flow | ||
|
|
||
| class ChartTrainerLocalDBDataSourceImpl @Inject constructor( |
There was a problem hiding this comment.
nit; 지금은 대부분 코드가 localDatasource하나에 모여있는데 모델을 어떻게 관리하고 나눌지에 따라서 여러개의 datasource로 나눠질수도 있습니다.
|
고생하셨습니다. ㅎㅎ 추가 코멘트는 다음 PR에서 적용해주세요~! |
f-lab-nathan
merged commit 30c395d
into
feature/ct-3-chart-game-data-network-source
2 checks passed
This was referenced Jun 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reference #3
이 PR을 보시기 전에 #19 PR -> #20 PR 을 보는 것이 순서에 맞습니다.
이 PR이 #3 의 마지막 PR입니다.
Overview