Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/#9/history api #11

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Refactor/#9/history api #11

wants to merge 2 commits into from

Conversation

EUNSUN23
Copy link
Collaborator

๐ŸŽ‹ ์ž‘์—…์ค‘์ธ ๋ธŒ๋žœ์น˜

Refactor/#9/history api


๐Ÿ’ก ์ž‘์—… ๋‚ด์šฉ

ํ’€ ๋ฆฌํ€˜์ŠคํŠธ์— ๋Œ€ํ•œ ๊ฐ„๋žตํ•œ ์„ค๋ช…์„ ์—ฌ๊ธฐ์— ์ž…๋ ฅํ•ด์ฃผ์„ธ์š”

1. History API๋กœ ๋ผ์šฐํŠธ ๊ด€๋ฆฌ - 9c77ffa

2. ์ฝ”๋“œ ๋ฆฌํฌ๋งท - 00c97e1


โœ๏ธ ๋น„๊ณ  (์„ ํƒ)

๋‹ค๋ฅธ ๋ฆฌ๋ทฐ์–ด ๋˜๋Š” ํŒ€์›์—๊ฒŒ ์ „๋‹ฌํ•˜๊ณ  ์‹ถ์€ ์ถ”๊ฐ€ ์ •๋ณด๋‚˜ ์š”์ฒญ์‚ฌํ•ญ์„ ์—ฌ๊ธฐ์— ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”.


โœ… Todo ๋ชฉ๋ก (์„ ํƒ)

ํ•„์š”ํ•œ ๊ฒฝ์šฐ ์ถ”๊ฐ€ ์ž‘์—…์ด๋‚˜ ๋ณ€๊ฒฝ ์‚ฌํ•ญ์„ ์ถ”์ ํ•˜๊ธฐ ์œ„ํ•ด Todo ๋ชฉ๋ก์„ ์—ฌ๊ธฐ์— ์ถ”๊ฐ€ํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.

@EUNSUN23 EUNSUN23 requested a review from f-lab-ash February 11, 2025 07:18
@EUNSUN23 EUNSUN23 self-assigned this Feb 11, 2025
@EUNSUN23 EUNSUN23 linked an issue Feb 11, 2025 that may be closed by this pull request
History API ์ ์šฉ #9
Open
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

f-lab-ash
f-lab-ash reviewed Feb 11, 2025
View reviewed changes
src/js/component/imageViewer/ImageViewer.ts
@@ -1,39 +1,39 @@
export type ImageViewerState = {
imgSrc: string;
isOpen: boolean;
imgSrc: string;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๐Ÿค” ์ฝ”๋“œ ํฌ๋งท ๊ธฐ์ค€์ด ๋ณ€ํ•œ ๊ฒƒ ๊ฐ™์•„์š” ํ™•์ธํ•ด์ฃผ์‹œ๊ฒ ์–ด์š”?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-lab-ash f-lab-ash f-lab-ash left review comments

Assignees

@EUNSUN23 EUNSUN23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

History API ์ ์šฉ
2 participants
@EUNSUN23 @f-lab-ash