구현 - 박스 오피스 순위 API 및 모델 추가 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
f-lab-james
approved these changes
Sep 3, 2024
| ...axiosConfig, | ||
| }); | ||
|
|
||
| return { data: camelCaseObjMapper(data), ...rest }; |
There was a problem hiding this comment.
저라면 그냥 이렇게 한 번에 처리할 것 같네요
return tmdbHttp.get('').then((res) => camelCaseObjMapper(res.data))| import { PopularMovieListRes } from "./response-types"; | ||
|
|
||
| export default class MovieListApi { | ||
| static baseURL = "movie"; |
There was a problem hiding this comment.
이건 외부에 노출시킬 필요도 없으니 8번째 라인쯤에서 관리해도 되겠네요
| "@vanilla-extract/dynamic": "*", | ||
| "@vanilla-extract/next-plugin": "*", | ||
| "@vanilla-extract/recipes": "*", | ||
| "@vanilla-extract/sprinkles": "*", |
There was a problem hiding this comment.
pnpm -r update @vanilla-extract/css@"^1.15.3"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 타입
연관 이슈
resolve #12
개요
변경 사항
Slot컴포넌트 추가Aspect-Ratio컴포넌트 추가리뷰시 참고할 사항