Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

구현 - 개봉 예정작 목록 구현 #20

Merged
merged 8 commits into from
Sep 12, 2024

Conversation

ag502
Copy link
Collaborator

@ag502 ag502 commented Sep 7, 2024

PR 타입

  • 기능 추가
  • 버그 수정
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트
  • 문서 수정
  • 기타

연관 이슈

resolve #19

개요

공개 예정작 목록 구현

변경 사항

  • upcoming-movie-list 모델 추가
  • upcoming-movie-list API 래핑 react-query 추가
  • upcoming-movie-card 컴포넌트 추가
  • upcoming-movie-list 컴포넌트 추가

리뷰시 참고할 사항

@ag502 ag502 added the feature label Sep 7, 2024
@ag502 ag502 requested a review from f-lab-james September 7, 2024 07:16
@ag502 ag502 self-assigned this Sep 7, 2024
@ag502 ag502 linked an issue Sep 7, 2024 that may be closed by this pull request
4 tasks
const swiperBreakPoints: SwiperOptions["breakpoints"] = useMemo(
() => ({
[parseInt(screenBreakPoints.sm)]: { slidesPerView: 4, spaceBetween: 12 },
[parseInt(screenBreakPoints.md)]: { slidesPerView: 5, spaceBetween: 16 },

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

컴포넌트 밖에 있어도 되는거 같네요

@ag502 ag502 changed the base branch from feature/8-fsd-architecture to develop September 12, 2024 20:38
Copy link

@ag502 ag502 merged commit e123732 into develop Sep 12, 2024
2 checks passed
@ag502 ag502 deleted the feature/19-upcoming-movie-list branch September 12, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] 공개 예정작 목록 구현
2 participants