구현 - 현재 상영중인 영화 목록 추가 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dev-boku
approved these changes
Oct 1, 2024
| @@ -9,6 +9,7 @@ import { MovieListReqParams } from "./request-types"; | |||
| export const movieListQueryKeys = { | |||
| popularMovieList: () => ["popular-movie-list"] as const, | |||
| upcomingMovieList: () => ["upcoming-movie-list"] as const, | |||
| nowPlayingMovieList: () => ["now-playing-movie-list"] as const, | |||
| }; | |||
There was a problem hiding this comment.
아래 팩토리 함수를 구현해서 all을 무조건 받을 수 있도록 만들어보시면 좋을 것 같습니다.
makeKeysFactory('movie-list', {
popularMovieList: () => ["popular-movie-list"] as const,
upcomingMovieList: () => ["upcoming-movie-list"] as const,
nowPlayingMovieList: () => ["now-playing-movie-list"] as const,
})| return this.movieList.results.filter(({ adult }) => !adult).map((item) => new MovieListItem(item)); | ||
| return this.movieList.results | ||
| .filter(({ adult }) => !adult) | ||
| .map((item) => new MovieListItem(item, this.genresModel)); | ||
| } |
There was a problem hiding this comment.
MovieListItem을 위해 genresModel을 넣어주는게 싫다면 외부에서 주입하는 것도 방법일 것 같습니다.
new MovieList().setXxx().setXxx().build()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 타입
연관 이슈
resolve #24
개요
상영중인 영화 목록 리스트 추가
변경 사항
리뷰시 참고할 사항