구현 - 상영중인 영화 리뷰 리스트 API 라우트 추가 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
f-lab-james
approved these changes
Oct 22, 2024
| [], | ||
| ); | ||
|
|
||
| res.status(200).send({ page: Number(page), results: nowPlayingMovieReviews }); |
There was a problem hiding this comment.
try 안에 있는 내용을 안에 고차함수로 넣고 메서드, 스키마를 넣으면 405, 422, 500 에러를 공통으로 처리하면 좋을 것 같습니다.
const querySchema = z.object({
page: z.string(),
query: z.number(),
region: z.string()
});
type Query = z.infer<typeof querySchema>;
withCommonHandler(() => {
}, HTTPMethod.GET, querySchema)| { language, region, page }: NowPlayingMovieListReviewsParams = { language: "ko-KR", region: "KR", page: 1 }, | ||
| ) => { | ||
| return useQuery({ | ||
| queryKey: [...reviewsQueryKeys.nowPlayingMovieList({ language, region, page })], |
There was a problem hiding this comment.
Suggested change
| queryKey: [...reviewsQueryKeys.nowPlayingMovieList({ language, region, page })], | |
| queryKey: reviewsQueryKeys.nowPlayingMovieList({ language, region, page }), |
| import { ReviewAuthorModel } from "./review-author"; | ||
|
|
||
| export class NowPlayingMovieReviewModel { | ||
| movieId: number; |
There was a problem hiding this comment.
tsdoc 달아두면 나중에 IDE에 도움을 받을 수 있어서 편리합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 타입
연관 이슈
resolve #25
개요
현재 상영중인 영화 리뷰 API 추가
변경 사항
react-query추가리뷰시 참고할 사항