Feature/UI #18
Merged
Feature/UI #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-dean
reviewed
Nov 30, 2024
| ) { | ||
| LazyVerticalGrid( | ||
| modifier = Modifier | ||
| .padding( |
There was a problem hiding this comment.
contentPadding을 사용하지 않고 Modifier의 padding을 사용한 이유는 무엇인가요?
| ) { | ||
| Icon( | ||
| modifier = Modifier.size(32.dp) | ||
| .clearAndSetSemantics { }, |
There was a problem hiding this comment.
clearAndSetSemantics는 어떤 의도로 추가했나요?
| .clearAndSetSemantics { }, | ||
| imageVector = SeeDocsIcon.PDF, | ||
| contentDescription = null, | ||
| tint = Color.Unspecified |
There was a problem hiding this comment.
Color.Unspecified 로 설정하신 이유가 궁금합니다.
|
|
||
| import androidx.lifecycle.ViewModel | ||
| import dagger.hilt.android.lifecycle.HiltViewModel | ||
| import javax.inject.Inject |
There was a problem hiding this comment.
의미없는 코드는 커밋에 포함되지 않도록 하시는게 좋을 것 같아요.
이를 방지하기 위해선 개발 계획을 잘 세우시는게 중요합니다.
| @@ -13,6 +18,21 @@ internal fun MainNavHost( | |||
| navController = navigator.navController, | |||
| startDestination = navigator.startDestination, | |||
| ) { | |||
| exploreNavGraph( | |||
| padding = padding, | |||
| navigateToPdf = { navigator.navigate(Route.Pdf){null} } | |||
There was a problem hiding this comment.
navigator.navigate(Route.Pdf){null}
코드 정렬 확인 부탁드립니다.
| .fillMaxSize() | ||
| .background(Theme.colors.bg) | ||
| ) { | ||
|
|
There was a problem hiding this comment.
구현이 필요한 코드는 TODO 코멘트를 남겨놓는 것도 괜찮은 방법입니다.
| Spacer(Modifier.height(32.dp)) | ||
|
|
||
| Text( | ||
| text = "북마크", |
There was a problem hiding this comment.
앱 내에 필요한 텍스트는 하드코딩보다 strings.xml 사용을 권장드립니다.
|
f-lab-dean
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.