Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: BookmarkRepositoryImplTest #43

Merged
merged 3 commits into from
Jan 19, 2025
Merged

Feat: BookmarkRepositoryImplTest #43

merged 3 commits into from
Jan 19, 2025

Conversation

Guri999
Copy link
Collaborator

@Guri999 Guri999 commented Jan 18, 2025

๐Ÿ“์ž‘์—… ๋‚ด์šฉ

๋ถ๋งˆํฌ ๋ ˆํฌ์ง€ํ† ๋ฆฌ ํ…Œ์ŠคํŠธ ์ž…๋‹ˆ๋‹ค.
Mapper ๊ฐ™์€ ๊ฒฝ์šฐ ์ €์žฅ ํ• ๋•Œ dao์—์„œ updateAt์„ ๋ณด๋‚ด์ง€ ์•Š์•„ ๊ธฐ๋ณธ๊ฐ’์ธ LocalDateTime.now๋กœ ์„ค์ •๋˜๊ธฐ ๋•Œ๋ฌธ์— mockk์œผ๋กœ ๋ฆฌํ„ด๊ฐ’์„ ์„ค์ •ํ•ด ์ฃผ์—ˆ์Šต๋‹ˆ๋‹ค

@Guri999 Guri999 self-assigned this Jan 18, 2025
f-lab-dean
f-lab-dean approved these changes Jan 18, 2025
View reviewed changes
Copy link

@f-lab-dean f-lab-dean left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
์ฝ”๋ฉ˜ํŠธ ํ™•์ธํ•˜์—ฌ ์ˆ˜์ • ํ›„ ๋จธ์ง€ํ•ด์ฃผ์„ธ์š”.

f-lab-dean
f-lab-dean reviewed Jan 18, 2025
View reviewed changes
core/data/src/test/kotlin/kr/co/data/repository/BookmarkRepositoryImplTest.kt Outdated
coEvery { toFileInfo(BOOKMARK_DUMMY) } returns PDF_DUMMY

repository.get().testWithItem {
assertEquals(this, files)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assertEquals(expected, actual) ์ˆœ์„œ์— ๋งž๊ฒŒ ํŒŒ๋ผ๋ฏธํ„ฐ ์ „๋‹ฌํ•ด์ฃผ์„ธ์š”.

@github-actions GitHub Actions
Copy link

Test Results

0 testsโ€‚โ€ƒโ€ƒ0 โœ…โ€ƒโ€ƒ0s โฑ๏ธ
0 suitesโ€ƒโ€ƒ0 ๐Ÿ’ค
0 filesโ€„โ€‚โ€ƒโ€ƒ0 โŒ

Results for commit d8c08fa.

@Guri999 Guri999 merged commit 344c062 into dev Jan 19, 2025
2 checks passed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-lab-dean f-lab-dean f-lab-dean approved these changes

Assignees

@Guri999 Guri999

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Guri999 @f-lab-dean