feat: 다크모드 기능 추가 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noah-f-lab
reviewed
Jul 2, 2023
hooks/useDarkMode.tsx
Outdated
Comment on lines
9
to
10
| ? window.localStorage.setItem('theme', 'light') | ||
| : window.localStorage.setItem('theme', 'dark'); |
There was a problem hiding this comment.
로컬스토리지를 한번 추상화해서 사용성을 높여보는 방법에 대해 고민 해보면 좋을 것 같습니다.
추가로 로컬스토리지를 사용 할 때 필요한 방어로직에 대해 찾아보세요.
There was a problem hiding this comment.
1999443#diff-15fcf2ea6bec1201344f5fb46963db5bd5f583b54b9b1184540e647f3ac566b5
로컬 스토리지를 유틸리티 기능으로 추상화하였고, 만료일을 설정해두어서 데이터 만료 처리를 할 수 있도록 수정해봤습니다~
KwangMin-bright-Moon
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5
작업 내용