-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create GitHub Action CI file #31
Open
f-meloni
wants to merge
7
commits into
master
Choose a base branch
from
f-meloni-patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3c4df8e
Create GitHub Action CI file
f-meloni 8c12771
Update swift.yml
f-meloni b7cc309
Update dependencies
f-meloni 4bbd45e
Update swift version
f-meloni 6c08ae2
Update Package.swift
f-meloni 346a854
Update xcodebuild
f-meloni da378c6
Update swift.yml
f-meloni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
name: CI | ||
|
||
on: [pull_request] | ||
|
||
jobs: | ||
build: | ||
runs-on: macos-11 | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- run: gem install bundler | ||
- run: bundle install | ||
- run: npm install -g danger | ||
- run: swift package generate-xcodeproj | ||
- run: xcodebuild test -scheme DangerSwiftCoverage-Package -derivedDataPath build/ -enableCodeCoverage YES | XCPRETTY_JSON_FILE_OUTPUT=result.json xcpretty -f `xcpretty-json-formatter` | ||
- run: DEBUG="*" swift run danger-swift ci | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Binary file added
BIN
+11.3 KB
...pm/xcode/package.xcworkspace/xcuserdata/franco.xcuserdatad/UserInterfaceState.xcuserstate
Binary file not shown.
66 changes: 66 additions & 0 deletions
66
.swiftpm/xcode/xcuserdata/franco.xcuserdatad/xcschemes/xcschememanagement.plist
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
<plist version="1.0"> | ||
<dict> | ||
<key>SchemeUserState</key> | ||
<dict> | ||
<key>DangerDeps.xcscheme_^#shared#^_</key> | ||
<dict> | ||
<key>orderHint</key> | ||
<integer>1</integer> | ||
</dict> | ||
<key>DangerSwiftCoverage-Package.xcscheme_^#shared#^_</key> | ||
<dict> | ||
<key>orderHint</key> | ||
<integer>0</integer> | ||
</dict> | ||
<key>DangerSwiftCoverage.xcscheme_^#shared#^_</key> | ||
<dict> | ||
<key>orderHint</key> | ||
<integer>2</integer> | ||
</dict> | ||
<key>SWXMLHashPlayground (Playground) 1.xcscheme</key> | ||
<dict> | ||
<key>isShown</key> | ||
<false/> | ||
<key>orderHint</key> | ||
<integer>5</integer> | ||
</dict> | ||
<key>SWXMLHashPlayground (Playground) 2.xcscheme</key> | ||
<dict> | ||
<key>isShown</key> | ||
<false/> | ||
<key>orderHint</key> | ||
<integer>6</integer> | ||
</dict> | ||
<key>SWXMLHashPlayground (Playground).xcscheme</key> | ||
<dict> | ||
<key>isShown</key> | ||
<false/> | ||
<key>orderHint</key> | ||
<integer>4</integer> | ||
</dict> | ||
<key>Test area (Playground) 1.xcscheme</key> | ||
<dict> | ||
<key>isShown</key> | ||
<false/> | ||
<key>orderHint</key> | ||
<integer>8</integer> | ||
</dict> | ||
<key>Test area (Playground) 2.xcscheme</key> | ||
<dict> | ||
<key>isShown</key> | ||
<false/> | ||
<key>orderHint</key> | ||
<integer>9</integer> | ||
</dict> | ||
<key>Test area (Playground).xcscheme</key> | ||
<dict> | ||
<key>isShown</key> | ||
<false/> | ||
<key>orderHint</key> | ||
<integer>7</integer> | ||
</dict> | ||
</dict> | ||
</dict> | ||
</plist> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
// swift-tools-version:5.1 | ||
// swift-tools-version:5.3 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you try setting this to 5.5? |
||
// The swift-tools-version declares the minimum version of Swift required to build this package. | ||
|
||
import PackageDescription | ||
|
@@ -14,23 +14,29 @@ let package = Package( | |
.library(name: "DangerDeps", type: .dynamic, targets: ["DangerDependencies"]), // dev | ||
], | ||
dependencies: [ | ||
.package(url: "https://github.com/danger/swift.git", from: "3.0.0"), | ||
.package(name: "danger-swift", url: "https://github.com/danger/swift.git", from: "3.0.0"), | ||
// Dev dependencies | ||
.package(url: "https://github.com/nicklockwood/SwiftFormat", from: "0.35.8"), // dev | ||
.package(url: "https://github.com/Realm/SwiftLint", from: "0.28.1"), // dev | ||
.package(url: "https://github.com/f-meloni/Rocket", from: "1.0.0"), // dev | ||
.package(url: "https://github.com/orta/Komondor", from: "1.0.0"), // dev | ||
.package(url: "https://github.com/f-meloni/danger-swift-xcodesummary", from: "1.0.0"), // dev | ||
.package(name: "DangerXCodeSummary", url: "https://github.com/f-meloni/danger-swift-xcodesummary", from: "1.0.0"), // dev | ||
], | ||
targets: [ | ||
.target(name: "DangerDependencies", dependencies: ["Danger", "DangerSwiftCoverage", "DangerXCodeSummary"]), // dev | ||
.target(name: "DangerDependencies", dependencies: [ | ||
.product(name: "Danger", package: "danger-swift"), | ||
"DangerSwiftCoverage", | ||
"DangerXCodeSummary", | ||
]), // dev | ||
.target( | ||
name: "DangerSwiftCoverage", | ||
dependencies: ["Danger"] | ||
dependencies: [ | ||
.product(name: "Danger", package: "danger-swift"), | ||
] | ||
), | ||
.testTarget( | ||
name: "DangerSwiftCoverageTests", | ||
dependencies: ["DangerSwiftCoverage", "DangerFixtures"] | ||
dependencies: ["DangerSwiftCoverage", .product(name: "DangerFixtures", package: "danger-swift")] | ||
), | ||
] | ||
) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generate-xcodeproj
is deprecated. We're now usingxcodebuild
directly through fastlane scan, which results in the following output:In other words, you can skip generating the Xcode project and just use
xcodebuild
directly on the packageThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I knew was deprecated, but didn't know I could use xcodebuild directly, that is pretty cool! thank you :)