-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] TESTS #63
base: feature-tests
Are you sure you want to change the base?
[WIP] TESTS #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments
configure({ adapter: new Adapter() }) | ||
|
||
describe('AlgoOrdersTable', () => { | ||
const data = [{"gid":"1585330269533","name":"MA Crossover","label":"MA Crossover | 1 @ MARKET | long EMA(1) | short EMA(0)","args":{"shortType":"EMA","longType":"EMA","amount":1,"shortMAPeriod":0,"longMAPeriod":0,"shortEMAPeriod":0,"longEMAPeriod":1,"shortMAPrice":"CLOSE","shortEMAPrice":"CLOSE","longMAPrice":"CLOSE","longEMAPrice":"CLOSE","shortMATF":"1m","longMATF":"1m","shortEMATF":"1m","longEMATF":"1m","orderType":"MARKET","orderPrice":0,"submitDelay":2,"cancelDelay":1,"_margin":false,"_futures":false,"symbol":"tBTCUSD","long":{"type":"ema","candlePrice":"close","candleTimeFrame":"1m","args":[1]},"short":{"type":"ema","candlePrice":"close","candleTimeFrame":"1m","args":[0]}},"exID":"bitfinex"}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please extract this into a separate JSON data file for the test.
apiClientState={2} | ||
/> | ||
)) | ||
component.find('.fa.fa-stop').simulate('click') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest you refactor the component to add a cancel-specific class that can be used here
<Settings /> | ||
</Provider> | ||
)) | ||
expect(component.find('.hfui-settings__option').length).toBe(2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As w/ the algo orders table, add classes for api key/secret and check for both here
1682e3d
to
8fb6542
Compare
No description provided.