mpi: fix setting local ranks #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #432 +/- ##
==========================================
+ Coverage 81.83% 81.93% +0.10%
==========================================
Files 115 115
Lines 7691 7702 +11
==========================================
+ Hits 6294 6311 +17
+ Misses 1397 1391 -6 ☔ View full report in Codecov by Sentry. |
csegarragonz
force-pushed
the
fix-destroy
branch
from
4f5a928 to
30782ef
Compare
In very constrained environments like GHA it may sometimes happen that some ranks _completely_ finish (i.e. call destroy) before others have even called Init. With our current implementation, this meant that the world may have been removed from the registry, even though there were still active local ranks to run. To fix this, we set the number of active local ranks once, at the beginning, and decrement it on a per-thread basis. Note that this does not invaliate the fix to the previous race condition because, in fact, what we fixed is that we now _always_ init a world when we execute in it.
csegarragonz
force-pushed
the
fix-destroy
branch
from
30782ef to
6666cff
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In very constrained environments like GHA it may sometimes happen that some ranks completely finish (i.e. call destroy) before others have even called Init.
With our current implementation, this meant that the world may have been removed from the registry, even though there were still active local ranks to run.
To fix this, we set the number of active local ranks once, at the beginning, and decrement it on a per-thread basis. Note that this does not invaliate the fix to the previous race condition because, in fact, what we fixed is that we now always init a world when we execute in it.