Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/attributed string #49

Merged
merged 9 commits into from
Jan 15, 2024
Merged

Conversation

alexandre-pod
Copy link
Member

This PR adds support for the helper method to generate AttributedString from a format, multiple Strings and different attributes to apply.
This evolution makes simpler to use attributed strings in SwiftUI Text.

@alexandre-pod alexandre-pod force-pushed the feature/AttributedString branch 2 times, most recently from 4182511 to 511639b Compare November 14, 2023 16:31
@faberNovel faberNovel deleted a comment from Bot-Fabernovel Nov 14, 2023
@alexandre-pod alexandre-pod force-pushed the feature/AttributedString branch 2 times, most recently from 0314d24 to 58b467e Compare November 14, 2023 17:00
This is needed as the bare slash regex is behind the feature flag "-enable-bare-slash-regex", and will be fully available in Swift 6.
See: https://github.com/apple/swift-evolution/blob/main/proposals/0354-regex-literals.md#source-compatibility
Copy link
Contributor

@ThibaultFarnier ThibaultFarnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manque le bump dans le podspec et une légère divergence sur le numéro de version à mettre à jour dans le changelog je crois, mais le reste est nickel, joli travail !

@alexandre-pod
Copy link
Member Author

Manque le bump dans le podspec et une légère divergence sur le numéro de version à mettre à jour dans le changelog je crois, mais le reste est nickel, joli travail !

Bien vu pour le problème de changelog, c'est corrigé. Et pour les numéros de version le bump se fait au niveau de la branche de release (avec la lane prepare_release)

@alexandre-pod alexandre-pod merged commit f955463 into develop Jan 15, 2024
2 checks passed
@alexandre-pod alexandre-pod deleted the feature/AttributedString branch January 15, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants