Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/escape percent character option #86

Merged
merged 8 commits into from
Sep 12, 2023

Conversation

alexandre-pod
Copy link
Member

On iOS when using String(format: ) we need to have % character escaped (with another % before). We can do that in the sheet when only iOS uses it, but for common sheet with Android it is not possible or %% will be displayed instead of %.

This PR adds the option --auto-escape-percent that escape % symbol when needed to solve this issue.

@peyronc
Copy link

peyronc commented Aug 23, 2023

on peut rajouter un test pour le d+ ie %10$@
pas sur que %% doive devenir %%
je pense que faut que %% du gsheet --> %%%% dans le .strings

@alexandre-pod alexandre-pod force-pushed the feature/escape_percent_character_option branch 2 times, most recently from b072fc7 to 245e7b1 Compare August 23, 2023 12:00
@alexandre-pod alexandre-pod force-pushed the feature/escape_percent_character_option branch from 245e7b1 to c5e7133 Compare August 23, 2023 12:13
@Nooba
Copy link
Contributor

Nooba commented Sep 4, 2023

Fonctionnellement ça me va. Je sais pas si @jvigne veut commenter aussi ?

@alexandre-pod alexandre-pod force-pushed the feature/escape_percent_character_option branch from 6000907 to 61286b2 Compare September 12, 2023 09:08
@alexandre-pod alexandre-pod merged commit ad98d58 into main Sep 12, 2023
6 checks passed
@alexandre-pod alexandre-pod deleted the feature/escape_percent_character_option branch September 12, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants