Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for API 34 #125

Merged
merged 2 commits into from
Dec 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions .ci/images_matrix.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,5 @@
{
"android_api": [
{
"api": 28,
"build_tools": "28.0.3"
},
{
"api": 29,
"build_tools": "29.0.3"
},
flolom marked this conversation as resolved.
Show resolved Hide resolved
{
"api": 30,
"build_tools": "30.0.3"
Expand All @@ -24,6 +16,10 @@
{
"api": 33,
"build_tools": "33.0.1"
},
{
"api": 34,
"build_tools": "34.0.0"
}
],
"android_ndk": [
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/daily_runner.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
options: --name=runner
strategy:
matrix:
android_api: [{ "api": 30, "build_tools": "30.0.3" }, { "api": 31, "build_tools": "32.0.0" }]
android_api: [{ "api": 33, "build_tools": "33.0.1" }, { "api": 34, "build_tools": "34.0.0" }]
android_ndk: ["--android-ndk"]
steps:
- name: Checkout
Expand Down
6 changes: 3 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,10 @@ RUN if [ "$gcloud" = true ] ; \
## Install Android SDK
ARG sdk_version=commandlinetools-linux-6200805_latest.zip
ARG android_home=/opt/android/sdk
ARG android_api=android-33
ARG android_build_tools=33.0.1
ARG android_api=android-34
ARG android_build_tools=34.0.0
ARG android_ndk=false
ARG ndk_version=25.1.8937393
ARG ndk_version=26.1.10909125
ARG cmake=3.22.1
RUN mkdir -p ${android_home} && \
wget --quiet --output-document=/tmp/${sdk_version} https://dl.google.com/android/repository/${sdk_version} && \
Expand Down
22 changes: 6 additions & 16 deletions tests/run_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ export BUILD_TOOLS_VERSION="$android_build_tools"
export MIN_SDK_VERSION=21
export TARGET_SDK_VERSION="$android_api"
export NDK_VERSION="21.0.6113669"
jenv global 17

setup_gradle_version() {
if grep -q "distributionUrl" ./gradle/wrapper/gradle-wrapper.properties; then
Expand All @@ -88,6 +87,7 @@ exec_test() {
ruby -v
eval "$(jenv init -)"

jenv global 17
if [ "$android_ndk" = true ]; then
echo "Running tests with ndk"
exec_test "$script_path"/test-app-ndk
Expand All @@ -97,22 +97,12 @@ else
fi

if [ "$large_test" = true ]; then
echo "Run android tests on Firebase Test Lab"
cd "$script_path"/test-firebase-test-lab

setup_gradle_version

bundle install
bundle exec fastlane android integrated_test
fi
echo "Run android tests on Firebase Test Lab"
cd "$script_path"/test-firebase-test-lab

if (( "$android_api" < 31 )); then
export GRADLE_VERSION="5.6.4"
export ANDROID_GRADLE_TOOLS_VERSION="3.6.1"
jenv global 1.8
exec_test "$script_path"/test-app-jdk-8
setup_gradle_version

jenv global 17
bundle install
bundle exec fastlane android integrated_test
fi

exit 0
9 changes: 0 additions & 9 deletions tests/test-app-jdk-8/.gitignore

This file was deleted.

1 change: 0 additions & 1 deletion tests/test-app-jdk-8/.ruby-version

This file was deleted.

6 changes: 0 additions & 6 deletions tests/test-app-jdk-8/Gemfile

This file was deleted.

228 changes: 0 additions & 228 deletions tests/test-app-jdk-8/Gemfile.lock

This file was deleted.

1 change: 0 additions & 1 deletion tests/test-app-jdk-8/app/.gitignore

This file was deleted.

40 changes: 0 additions & 40 deletions tests/test-app-jdk-8/app/build.gradle

This file was deleted.

Loading
Loading