Skip to content

Commit

Permalink
feat: make Heart works with Node.js version 21 (#201)
Browse files Browse the repository at this point in the history
* ci: run tests with the shiny new Node.js version 21
* chore: allows Rush to be run on Node.js 21
* feat: allows Node.js 21
* docs: add changelogs
* ci: use latest checkout action

---------

Co-authored-by: Bastien Gatellier <[email protected]>
  • Loading branch information
bgatellier and bgatellier authored Jan 14, 2024
1 parent ad0ff1c commit 14cfe3f
Show file tree
Hide file tree
Showing 23 changed files with 107 additions and 17 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/coverage.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
reports_path: ${{ steps.list_reports_path.outputs.reports_path }}

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: actions/setup-node@v3
with:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
shell: bash

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 2

Expand Down Expand Up @@ -44,10 +44,10 @@ jobs:
shell: bash
strategy:
matrix:
node_version: [18, 19, 20]
node_version: [18, 19, 20, 21]

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: actions/setup-node@v3
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
contents: write

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 2
ref: ${{ env.SOURCE_BRANCH }}
Expand Down Expand Up @@ -85,7 +85,7 @@ jobs:
pull-requests: write

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 2
ref: ${{ env.SOURCE_BRANCH }}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@fabernovel/heart-api",
"comment": "Add compatibility with Node.js 21",
"type": "minor"
}
],
"packageName": "@fabernovel/heart-api"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@fabernovel/heart-cli",
"comment": "Add compatibility with Node.js 21",
"type": "minor"
}
],
"packageName": "@fabernovel/heart-cli"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@fabernovel/heart-common",
"comment": "Add compatibility with Node.js 21",
"type": "minor"
}
],
"packageName": "@fabernovel/heart-common"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@fabernovel/heart-greenit",
"comment": "Add compatibility with Node.js 21",
"type": "minor"
}
],
"packageName": "@fabernovel/heart-greenit"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@fabernovel/heart-lighthouse",
"comment": "Add compatibility with Node.js 21",
"type": "minor"
}
],
"packageName": "@fabernovel/heart-lighthouse"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@fabernovel/heart-mysql",
"comment": "Add compatibility with Node.js 21",
"type": "minor"
}
],
"packageName": "@fabernovel/heart-mysql"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@fabernovel/heart-observatory",
"comment": "Add compatibility with Node.js 21",
"type": "minor"
}
],
"packageName": "@fabernovel/heart-observatory"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@fabernovel/heart-slack",
"comment": "Add compatibility with Node.js 21",
"type": "minor"
}
],
"packageName": "@fabernovel/heart-slack"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@fabernovel/heart-ssllabs-server",
"comment": "Add compatibility with Node.js 21",
"type": "minor"
}
],
"packageName": "@fabernovel/heart-ssllabs-server"
}
2 changes: 1 addition & 1 deletion modules/api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"@fabernovel/heart-cli": "^4.0.0"
},
"engines": {
"node": ">=18 <21"
"node": ">=18 <22"
},
"heart": {
"id": "api",
Expand Down
2 changes: 1 addition & 1 deletion modules/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,6 @@
"typescript": "^5.3.3"
},
"engines": {
"node": ">=18 <21"
"node": ">=18 <22"
}
}
2 changes: 1 addition & 1 deletion modules/common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,6 @@
"typescript": "^5.3.3"
},
"engines": {
"node": ">=18 <21"
"node": ">=18 <22"
}
}
2 changes: 1 addition & 1 deletion modules/greenit/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"@fabernovel/heart-cli": "^4.0.0"
},
"engines": {
"node": ">=18 <21"
"node": ">=18 <22"
},
"heart": {
"id": "greenit",
Expand Down
2 changes: 1 addition & 1 deletion modules/lighthouse/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"@fabernovel/heart-cli": "^4.0.0"
},
"engines": {
"node": ">=18 <21"
"node": ">=18 <22"
},
"heart": {
"id": "lighthouse",
Expand Down
2 changes: 1 addition & 1 deletion modules/mysql/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"@fabernovel/heart-cli": "^4.0.0"
},
"engines": {
"node": ">=18 <21"
"node": ">=18 <22"
},
"heart": {
"id": "mysql",
Expand Down
2 changes: 1 addition & 1 deletion modules/observatory/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"@fabernovel/heart-cli": "^4.0.0"
},
"engines": {
"node": ">=18 <21"
"node": ">=18 <22"
},
"heart": {
"id": "observatory",
Expand Down
2 changes: 1 addition & 1 deletion modules/slack/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"@fabernovel/heart-cli": "^4.0.0"
},
"engines": {
"node": ">=18 <21"
"node": ">=18 <22"
},
"heart": {
"id": "slack",
Expand Down
2 changes: 1 addition & 1 deletion modules/ssllabs-server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"@fabernovel/heart-cli": "^4.0.0"
},
"engines": {
"node": ">=18 <21"
"node": ">=18 <22"
},
"heart": {
"id": "ssllabs-server",
Expand Down
2 changes: 1 addition & 1 deletion modules/tpl/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"@fabernovel/heart-cli": "^4.0.0"
},
"engines": {
"node": ">=18 <21"
"node": ">=18 <22"
},
"heart": {
"id": "tpl",
Expand Down
2 changes: 1 addition & 1 deletion rush.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
* Specify a SemVer range to ensure developers use a NodeJS version that is appropriate
* for your repo.
*/
"nodeSupportedVersionRange": ">=18 <21",
"nodeSupportedVersionRange": ">=18 <22",

/**
* If you would like the version specifiers for your dependencies to be consistent, then
Expand Down

0 comments on commit 14cfe3f

Please sign in to comment.