refactor: optimize the database connection creation

modules/mysql/src/MySQLModule.ts

@@ -9,37 +9,37 @@ import { MikroORM } from "@mikro-orm/core"
 import { type MySqlDriver } from "@mikro-orm/mysql"
 import databaseConfig from "./config/mikro-orm.config.js"
 
-function createDatabaseClient(): Promise<MikroORM> {
-  return MikroORM.init<MySqlDriver>(databaseConfig)
-}
-
 export class MySQLModule extends Module implements ModuleListenerDatabaseInterface {
+  #orm: Promise<MikroORM<MySqlDriver>> | undefined
+
   public async hasPendingMigrations(): Promise<boolean> {
-    const orm = await createDatabaseClient()
+    const orm = await this.getOrCreateDatabaseClient()
     const migrator = orm.getMigrator()
 
     const migrations = await migrator.getPendingMigrations()
 
-    await orm.close(true)
-
     return migrations.length > 0
   }
 
   public async runPendingMigrations(): Promise<void> {
-    const orm = await createDatabaseClient()
+    const orm = await this.getOrCreateDatabaseClient()
     const migrator = orm.getMigrator()
 
     await migrator.up()
-
-    return orm.close(true)
   }
 
   public async notifyAnalysisDone(report: GenericReport<Result>): Promise<void> {
-    const orm = await createDatabaseClient()
+    const orm = await this.getOrCreateDatabaseClient()
     const reportEntity = new ReportEntity<Result>(report)
 
     await orm.em.persistAndFlush(reportEntity)
 
-    return orm.close(true)
+    console.log("entity persisted and flushed")
+
+    return orm.close()
+  }
+
+  private async getOrCreateDatabaseClient(): Promise<MikroORM<MySqlDriver>> {
+    return this.#orm ?? MikroORM.init<MySqlDriver>(databaseConfig)
   }
 }