Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use
interface
instead oftype
for all Base types #259Use
interface
instead oftype
for all Base types #259Changes from 25 commits
fd86987
990140a
cc38e4f
5b483f4
a6bbcd1
a1584f1
c08f732
7f84338
cab5616
a89b486
3b2d314
1b516da
5078f72
27dec16
6949d2d
c2dc365
527a05c
e5c79ca
0a426bb
e195488
0676aff
0604c26
bb424a0
b6a2fb2
0a5889a
fe36ae1
9574d5d
2a28529
48ce458
02b17d5
2cefacc
114b1f8
e08af7f
03e95e3
7e79352
2f77fc2
de1d857
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this into
getDefaults.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved these types because they created a circular dependency reference. IMO they are better kept in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does it create a circular dependency reference? I prefer to move it to
getDefaults.ts
to be consistent with the rest of the source code. Types that are related to a particular function are placed above the function in the same file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because for example:
in
types.ts
would import fromgetDefaults.ts
, which itself importsDefaultValue
fromtypes,ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will have a look at it. I don't think this is a problem but I could be wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this into
getDefaultsAsync.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move that into
getFallback.ts
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move that into
getFallbackAsync.ts
.