fixed LLVMAliasSetSerializationTest

fabianbs96 · Apr 17, 2024 · 47bf183 · 47bf183
1 parent 16bbf2a
commit 47bf183
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 12 deletions.
diff --git a/lib/PhasarLLVM/Pointer/LLVMAliasSet.cpp b/lib/PhasarLLVM/Pointer/LLVMAliasSet.cpp
@@ -727,8 +727,6 @@ LLVMAliasSetData LLVMAliasSet::getLLVMAliasSetData() const {
   LLVMAliasSetData Data;
 
   /// Serialize the AliasSets
-  auto &AliasSetsDataPosition = Data.AliasSets.emplace_back();
-
   for (const AliasSetTy *PTS : Owner.getAllAliasSets()) {
 
     std::vector<std::string> PtsJson{};
@@ -739,6 +737,7 @@ LLVMAliasSetData LLVMAliasSet::getLLVMAliasSetData() const {
       }
     }
     if (!PtsJson.empty()) {
+      auto &AliasSetsDataPosition = Data.AliasSets.emplace_back();
       for (const auto &Curr : PtsJson) {
         AliasSetsDataPosition.push_back(Curr);
       }

diff --git a/unittests/PhasarLLVM/Pointer/LLVMAliasSetSerializationTest.cpp b/unittests/PhasarLLVM/Pointer/LLVMAliasSetSerializationTest.cpp
@@ -39,7 +39,6 @@ static SetTy makeSet(const nlohmann::json &J) {
 }
 
 static void checkSer(const nlohmann::json &Ser, const GroundTruthTy &Gt) {
-
   ASSERT_TRUE(Ser.count("AliasSets"));
   ASSERT_TRUE(Ser.count("AnalyzedFunctions"));
 
@@ -77,20 +76,11 @@ static void analyze(llvm::StringRef File, const GroundTruthTy &Gt,
   ValueAnnotationPass::resetValueID();
   LLVMProjectIRDB IRDB(unittest::PathToLLTestFiles + File);
 
-  // llvm::outs() << *IRDB.getWPAModule() << '\n';
-
   LLVMAliasSet PTS(&IRDB, false);
   LLVMTypeHierarchy TH(IRDB);
   LLVMBasedICFG ICF(&IRDB, CallGraphAnalysisType::OTF, {EntryPoint.str()}, &TH,
                     &PTS);
 
-  auto Ser = PTS.getAsJson();
-  checkSer(Ser, Gt);
-
-  LLVMAliasSet Deser(&IRDB, Ser);
-  checkDeser(*IRDB.getModule(), PTS, Deser);
-
-  // printAsJson serialization
   std::string SerString;
   llvm::raw_string_ostream StringStream(SerString);
   PTS.printAsJson(StringStream);