fix(typescript): Handle invalid type names #317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently saw that there is an issue with certain names in the schema.
The schema above will generate the definition
export type 400 = void
where 400 is an invalid identifier.The problem happens in schemaToTypeAliasDeclaration as the name is used without any check for its validity.
I addressed this issue by prepending invalid names by
_
and if they are still invalid, by removing any non A-Za-z0-9 characters.It might cause collisions though if you have e.g.
400
and_400
, or you use a schema full of e.g. emojis as names.