Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scale the camera to keep the banana in view #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marler8997
Copy link

Addresses issue #1

@marler8997 marler8997 force-pushed the scaleCameraBananaView branch from 0c4b02e to 78ae900 Compare March 3, 2021 19:03
@fabioarnold
Copy link
Owner

Interesting solution to this problem. 😅

And it can lead to situations like this:
zoom

I think we either have to generate more buildings or don't zoom and move the camera up and follow the banana. 😄
We could expand the gradient like this:
gradient

What do you think?

@marler8997
Copy link
Author

that gradient looks great, I like it.

yeah not having the building looks a bit weird. I think I liked the look of zooming out to see the whole scene with the banana way up there and the city below, but I don't really know what the other method would look like to be fair. Generating more buildings seems like a reasonable solution if we want to go that route.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants