-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use dashingjs as a module rather as a server #8
base: master
Are you sure you want to change the base?
Conversation
Will this be accepted or is it not in the interest of the project? I'd like to do a similar thing and extend it. |
Can you show me an example on how you load dashing-js from you existing project? |
@@ -2,36 +2,58 @@ var fs = require('fs') | |||
, path = require('path') | |||
, express = require('express') | |||
, Mincer = require('mincer') | |||
, coffee = require('coffee-script'); | |||
, coffee = require('coffee-script') | |||
, _ = require('underscore'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really necessary, add underscore.js as a dependency only for extend?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
absolutely not, sorry :) Please refactor as needed, it was the first thing on my head.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was not a critic :) Did you see my other comment on this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw your other comments just now. I'll put up an example some where.
Hello! |
I wanted to use dashing to be part of our internal dashboard, but want to use it inside another nodejs server rather a separate server. These are the changes I made in order to make it work.
dashing.app
as a module