Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use dashingjs as a module rather as a server #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

constantx
Copy link

I wanted to use dashing to be part of our internal dashboard, but want to use it inside another nodejs server rather a separate server. These are the changes I made in order to make it work.

  • add index.js that export dashing.app as a module
  • add root to mincer paths for it to be look up correctly when dashing is a subfolder of the main projet
  • add options to override some paths

@darrenhaken
Copy link

Will this be accepted or is it not in the interest of the project?

I'd like to do a similar thing and extend it.

@ghost ghost assigned fabiocaseri Nov 29, 2013
@fabiocaseri
Copy link
Owner

Can you show me an example on how you load dashing-js from you existing project?

@@ -2,36 +2,58 @@ var fs = require('fs')
, path = require('path')
, express = require('express')
, Mincer = require('mincer')
, coffee = require('coffee-script');
, coffee = require('coffee-script')
, _ = require('underscore');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really necessary, add underscore.js as a dependency only for extend?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absolutely not, sorry :) Please refactor as needed, it was the first thing on my head.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not a critic :) Did you see my other comment on this PR?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabiocaseri 🍻

Saw your other comments just now. I'll put up an example some where.

@KhrystynaLoginova
Copy link

Hello!
I have mongo-express-node project in which I need to use dashing-js to display results of using lib node-sensortag. How can I use dashing-js as a module?
Really need to answer, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants