Enable proper termination of ProcessServer #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just merged. Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently not possible to stop the Debug Server, because the underlying ProcessServer does not support proper termination.
The following code is used to shutdown the process:
https://github.com/eclipse-platform/eclipse.platform/blob/ebe8db5d9d1c7d231be261d9fd5207dfc94ca9a0/debug/org.eclipse.debug.core/core/org/eclipse/debug/core/model/RuntimeProcess.java#L243-L293
The call to
waitFor(...)queries the exit value of the process, which always throws anIllegalThreadStateException, indicating that the process is still running, and thus leading to a timeout. I changed the implementation, such thatexitValue()returns zero, if the process has been terminated.The easiest way to reproduce this is to start/stop the debug server via the Pydev menu. When stopping the server, the UI will freeze until the timeout occurs