Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove left-overs of code completion in breakpoint properties #369

Merged

Conversation

FlorianKroiss
Copy link
Contributor

Eclipse 2024-03 removed some APIs that have been deprecated for several years. Some of these APIs have been used in the Breakpoint Property Editor to enable/disable the handlers used for code completion of conditional breakpoints. However, code completion for conditional breakpoints seems to have been commented out for > 18 years. So I went ahead and removed the commented code as well the usages of the deprecated APIs.

I know that a better but much more time consuming solution would have been to reimplement code completion, but I currently don't have the time to do this. Since the code completition wasn't working anyway, I believe that this change doesn't do any harm, but allows using PyDev with Eclipse 2024-03 onwards. In case someone wants to implement code completion again, the changes are still visible in the git history.

@fabioz fabioz merged commit 91f03d3 into fabioz:master May 4, 2024
1 check passed
@fabioz
Copy link
Owner

fabioz commented May 4, 2024

Thanks for the PR. Just applied.

@FlorianKroiss FlorianKroiss deleted the remove-unused-code-completion-code branch May 6, 2024 07:15
@FlorianKroiss
Copy link
Contributor Author

Hi @fabioz

is it possible to create a new point release containing this and the other recently merged fixes?

@fabioz
Copy link
Owner

fabioz commented May 23, 2024

Yes, I'm also missing a release myself (I still didn't have the time to do it, but my plan is doing it soon).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants