Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export 'org.python.pydev.compare' package #370

Merged
merged 2 commits into from
Aug 25, 2024
Merged

Conversation

thahnen
Copy link
Contributor

@thahnen thahnen commented Aug 19, 2024

Summary

This fixes the issue 1259.

In order to access and use the classes, including PyMergeViewer, the package must be exported.

Disclaimer

In case no PRs are allowed, e.g. because I never committed to this repository, then here is the patch file. I had to zip it as GitHub doesn't allow to append those file types to it.

PyDev-1259.zip

@thahnen
Copy link
Contributor Author

thahnen commented Aug 20, 2024

HI @fabioz, the build fails due to this line. Apparently the setup Java action was changed in the meantime to move to 17.0.12+7.

Instead of checking for the exact Java version folder name, I would change it to find /opt/hostedtoolcache/Java_Adopt_jdk/17.*/x64/ -name "*.jar" in order to work correctly with this action updating once every now and then.

@fabioz fabioz merged commit 58b794f into fabioz:master Aug 25, 2024
@fabioz
Copy link
Owner

fabioz commented Aug 25, 2024

Thank you for the PR! Just merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants