Add register with URL overload to ServiceWorkerContainer

Fix #141
fable-compiler · Sep 20, 2024 · 2e8080d · 2e8080d
1 parent 8300b75
commit 2e8080d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/src/Worker/Browser.Worker.fs b/src/Worker/Browser.Worker.fs
@@ -73,6 +73,7 @@ type [<Global>] ServiceWorkerContainer =
     abstract onerror: (Event -> unit) with get, set
     abstract onmessage: (Event -> unit) with get, set
     abstract register: url: string * ?options: ServiceWorkerRegistrationOptions -> JS.Promise<ServiceWorkerRegistration>
+    abstract register: url: URL * ?options: ServiceWorkerRegistrationOptions -> JS.Promise<ServiceWorkerRegistration>
     abstract getRegistration: ?scope: string -> JS.Promise<ServiceWorkerRegistration>
     abstract getRegistrations: unit -> JS.Promise<ServiceWorkerRegistration[]>
     abstract startMessages: unit -> unit

diff --git a/src/Worker/Browser.Worker.fsproj b/src/Worker/Browser.Worker.fsproj
@@ -2,8 +2,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <PackageId>Fable.Browser.Worker</PackageId>
-    <Version>1.3.0</Version>
-    <PackageVersion>1.3.0</PackageVersion>
+    <Version>1.4.0</Version>
+    <PackageVersion>1.4.0</PackageVersion>
     <TargetFramework>netstandard2.0</TargetFramework>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <Tags>fable;fable-binding;fable-javascript</Tags>
@@ -16,6 +16,7 @@
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\Event\Browser.Event.fsproj" />
+    <ProjectReference Include="..\Url\Browser.Url.fsproj" />
   </ItemGroup>
   <!-- This package doesn't contain actual code
        so we don't need to add the sources -->

diff --git a/src/Worker/RELEASE_NOTES.md b/src/Worker/RELEASE_NOTES.md
@@ -1,3 +1,7 @@
+### 1.4.0 
+
+* Add `abstract register: url: URL * ?options: ServiceWorkerRegistrationOptions -> JS.Promise<ServiceWorkerRegistration>` overload to `ServiceWorkerContainer` (by @MangelMaxime)
+
 ### 1.3.0 
 
 * Align Fable.Core version to 3.2.8 for all of fable-browser packages