Skip to content

Commit

Permalink
docs(attention): fix typo in popover Attention examples (#166)
Browse files Browse the repository at this point in the history
* docs(attention): fix typo in popover Attention examples (#166)

* fix(css): point at version 1 of fabric-ds/css to handle focus-ring classes
Use the latest alias of fabric-ds/css package in the test, documentation and storybook environment
  • Loading branch information
BalbinaK authored Nov 9, 2022
1 parent 8a8cd66 commit 4ce9c82
Show file tree
Hide file tree
Showing 10 changed files with 20 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .storybook/preview-head.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<link
href="https://assets.finn.no/pkg/@fabric-ds/css/v0/fabric.min.css"
href="https://assets.finn.no/pkg/@fabric-ds/css/v1/fabric.min.css"
rel="stylesheet"
/>
2 changes: 1 addition & 1 deletion index.html
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
}
</style>
<link
href="https://assets.finn.no/pkg/@fabric-ds/css/v0/fabric.min.css"
href="https://assets.finn.no/pkg/@fabric-ds/css/v1/fabric.min.css"
rel="stylesheet"
/>
<link
Expand Down
7 changes: 6 additions & 1 deletion packages/attention/docs/Attention.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,12 @@ function Example() {
>
Open menu
</Button>
<Attention popver placement="bottom" targetEl={targetEl} isShowing={show}>
<Attention
popover
placement="bottom"
targetEl={targetEl}
isShowing={show}
>
<ul className="bg-white w-full text-center">
<li
tabIndex={0}
Expand Down
7 changes: 6 additions & 1 deletion packages/attention/stories/Attention.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,12 @@ export function Popover() {
>
Open menu
</Button>
<Attention popver placement="bottom" targetEl={targetEl} isShowing={show}>
<Attention
popover
placement="bottom"
targetEl={targetEl}
isShowing={show}
>
<ul className="bg-white w-full text-center">
<li
tabIndex={0}
Expand Down
2 changes: 1 addition & 1 deletion tests/eik-react-jsx/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<title>Fabric React</title>
<meta name="viewport" content="width=device-width, initial-scale=1" />
<link
href="https://assets.finn.no/pkg/@fabric-ds/css/v0/fabric.min.css"
href="https://assets.finn.no/pkg/@fabric-ds/css/v1/fabric.min.css"
rel="stylesheet"
/>
</head>
Expand Down
2 changes: 1 addition & 1 deletion tests/eik-react/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<title>Fabric React</title>
<meta name="viewport" content="width=device-width, initial-scale=1" />
<link
href="https://assets.finn.no/pkg/@fabric-ds/css/v0/fabric.min.css"
href="https://assets.finn.no/pkg/@fabric-ds/css/v1/fabric.min.css"
rel="stylesheet"
/>
</head>
Expand Down
2 changes: 1 addition & 1 deletion tests/ssr-react-16-cjs/src/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ server.get('/', (request, reply) => {
<meta charset="UTF-8" />
<title>Fabric React</title>
<meta name="viewport" content="width=device-width, initial-scale=1" />
<link href="https://assets.finn.no/pkg/@fabric-ds/css/v0/fabric.min.css" rel="stylesheet" />
<link href="https://assets.finn.no/pkg/@fabric-ds/css/v1/fabric.min.css" rel="stylesheet" />
</head>
<body>
<div id="app">${markup}</div>
Expand Down
2 changes: 1 addition & 1 deletion tests/ssr-react-16/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ server.get('/', (request, reply) => {
<meta charset="UTF-8" />
<title>Fabric React</title>
<meta name="viewport" content="width=device-width, initial-scale=1" />
<link href="https://assets.finn.no/pkg/@fabric-ds/css/v0/fabric.min.css" rel="stylesheet" />
<link href="https://assets.finn.no/pkg/@fabric-ds/css/v1/fabric.min.css" rel="stylesheet" />
</head>
<body>
<div id="app">${markup}</div>
Expand Down
2 changes: 1 addition & 1 deletion tests/ssr-react-ts-16-cjs/src/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ server.get('/', (request, reply) => {
<meta charset="UTF-8" />
<title>Fabric React</title>
<meta name="viewport" content="width=device-width, initial-scale=1" />
<link href="https://assets.finn.no/pkg/@fabric-ds/css/v0/fabric.min.css" rel="stylesheet" />
<link href="https://assets.finn.no/pkg/@fabric-ds/css/v1/fabric.min.css" rel="stylesheet" />
</head>
<body>
<div id="app">${markup}</div>
Expand Down
2 changes: 1 addition & 1 deletion tests/ssr-react-ts-16/src/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ server.get('/', (request, reply) => {
<meta charset="UTF-8" />
<title>Fabric React</title>
<meta name="viewport" content="width=device-width, initial-scale=1" />
<link href="https://assets.finn.no/pkg/@fabric-ds/css/v0/fabric.min.css" rel="stylesheet" />
<link href="https://assets.finn.no/pkg/@fabric-ds/css/v1/fabric.min.css" rel="stylesheet" />
</head>
<body>
<div id="app">${markup}</div>
Expand Down

0 comments on commit 4ce9c82

Please sign in to comment.