make slider trigger onChange also on click #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the slider call
onChange
also when the user clicks on the slider track, not just after dragging the slider thumbs.Problem:
When clicking the slider track,
onChange
is not called, even though the input values are changed (andonInput
is called). This prevents the eg. the search result page from updating the user's search when clicking on a slider filter.Solution:
Since
active
istrue
while the user interacts with the slider, andfalse
afterwards, we can use this state to trigger theonChange
callback.