fix(timeout): Fix stack report polling frequency and duration (#338)

Fixes stack report polling duration to 20s and polling frequency to 2s. This PR fixes VSIX side of issue #304. Also it handles new HTTP error code which got introduced part of fabric8-analytics/fabric8-analytics-server#576.
fabric8-analytics · Sep 3, 2019 · 96f8d09 · 96f8d09
1 parent 301258e
commit 96f8d09
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/src/constants.ts b/src/constants.ts
@@ -12,3 +12,7 @@ export enum GlobalState {
 export const extensionId = 'fabric8-analytics';
 // publisher.name from package.json
 export const extensionQualifiedId = `redhat.${extensionId}`;
+// GET request timeout
+export const getRequestTimeout = 20 * 1000; // ms
+// GET request polling frequency
+export const getRequestPollInterval = 2 * 1000; // ms
diff --git a/src/stackAnalysisService.ts b/src/stackAnalysisService.ts
@@ -92,6 +92,11 @@ export module stackAnalysisServices {
               httpResponse.statusCode
             } - ${httpResponse.statusMessage} `;
             reject(errorMsg);
+          } else if (httpResponse.statusCode === 408) {
+            errorMsg = `Stack analysis request has timed out. Status:  ${
+              httpResponse.statusCode
+            } - ${httpResponse.statusMessage} `;
+            reject(errorMsg);
           } else {
             clearContextInfo(context);
             errorMsg = `Failed to trigger application's stack analysis, try in a while. Status: ${

diff --git a/src/stackanalysismodule.ts b/src/stackanalysismodule.ts
@@ -4,6 +4,7 @@ import * as vscode from 'vscode';
 import * as paths from 'path';
 
 import { Apiendpoint } from './apiendpoint';
+import { getRequestTimeout, getRequestPollInterval } from './constants';
 import { multimanifestmodule } from './multimanifestmodule';
 import { ProjectDataProvider } from './ProjectDataProvider';
 import { stackAnalysisServices } from './stackAnalysisService';
@@ -70,7 +71,7 @@ export module stackanalysismodule {
               }stack-analyses/${respId}?user_key=${
                 Apiendpoint.STACK_API_USER_KEY
               }`;
-              let couterGetSa = 0;
+              let timeoutCounter = getRequestTimeout / getRequestPollInterval;
               const interval = setInterval(() => {
                 stackAnalysisServices
                   .getStackAnalysisService(options)
@@ -85,8 +86,9 @@ export module stackanalysismodule {
                       }
                       resolve();
                     } else {
-                      couterGetSa++;
-                      if (couterGetSa >= 17) {
+                      console.log(`Polling for stack report, remaining count:${timeoutCounter}`);
+                      --timeoutCounter;
+                      if (timeoutCounter <= 0) {
                         let errMsg = `Failed to trigger application's stack analysis, try in a while.`;
                         clearInterval(interval);
                         p.report({
@@ -106,7 +108,7 @@ export module stackanalysismodule {
                     handleError(error);
                     reject(error);
                   });
-              }, 7000);
+              }, getRequestPollInterval);
             })
             .catch(err => {
               p.report({